Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(duckdb): parenthesize argument to StructField operation to support field access on CASE statements #8486

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Feb 28, 2024

Fixes #8485.

@cpcloud cpcloud added this to the 9.0 milestone Feb 28, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis duckdb The DuckDB backend labels Feb 28, 2024
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cpcloud cpcloud enabled auto-merge (squash) February 28, 2024 15:24
@cpcloud cpcloud added the ci-run-cloud Add this label to trigger a run of Bigquery and Snowflake in CI label Feb 28, 2024
@ibis-docs-bot ibis-docs-bot bot removed the ci-run-cloud Add this label to trigger a run of Bigquery and Snowflake in CI label Feb 28, 2024
@cpcloud cpcloud enabled auto-merge (squash) February 28, 2024 16:00
@cpcloud cpcloud merged commit 1371016 into ibis-project:main Feb 28, 2024
74 checks passed
@cpcloud cpcloud deleted the fix-struct-case-duckdb branch February 28, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis duckdb The DuckDB backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(duckdb): struct field access on CASE generates SQL that duckdb cannot parse
2 participants