Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): support python 3.12 #8529

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Mar 3, 2024

Add 3.12 job and support in our nix builds and environment; fixes warnings about utcfromtimestamp from ibis code and ignores them in testing due to their use at the top level of dateutil.

@cpcloud cpcloud added this to the 9.0 milestone Mar 3, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis dependencies Issues or PRs related to dependencies labels Mar 3, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Mar 3, 2024

Looks like only DuckDB >=0.10 supports Python 3.12 :( We've merged in DuckDB 0.10 support.

@cpcloud cpcloud force-pushed the python312 branch 5 times, most recently from 252fa9f to b1443c7 Compare March 8, 2024 11:09
@cpcloud
Copy link
Member Author

cpcloud commented Mar 8, 2024

I realize we have a 3-Python-version policy (I think we wrote that down somewhere), so I didn't add a 3.12 job anywhere that would significantly increase CI job count. For example, all backend workflows (except PySpark because in the past that has been annoying) did not get a 3.12 job.

@cpcloud cpcloud requested a review from gforsyth March 8, 2024 14:52
@gforsyth
Copy link
Member

gforsyth commented Mar 8, 2024

NEP 29 drop-date for Python 3.9 is April 5th, 2024, so either way we'll be back to 3 python versions fairly shortly.

Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gforsyth gforsyth merged commit a4eb2d2 into ibis-project:main Mar 8, 2024
78 checks passed
@cpcloud cpcloud deleted the python312 branch May 10, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis dependencies Issues or PRs related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants