fix(common): Node.map_clear should have return type annotation Any
#8564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it returned `dict`, just as `Node.map`
kszucs
changed the title
Node.map_clear should return AnyNode.map_clear should return type annotation Any
kszucs
changed the title
Node.map_clear should return type annotation AnyNode.map_clear should have return type annotation Any
kszucs
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Previously
Node.map_clearhad adictreturn type annotation, just asNode.map, even though the main rationale behindmap_clearis that it returns only the result of the root node and discards all the intermediaries.