refactor(sql): simplify FirstValue/LastValue usage
#8568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
reviewed
Mar 6, 2024
…for SQL window functions
jcrist
force-pushed
the
refactor-first-last-value
branch
from
cf29fad
to
01e2ec9
Compare
kszucs
changed the title
FirstValue/LastValue usageFirstValue/LastValue usage
kszucs
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During recent refactors the
FirstValue/LastValuehave been pretty much removed from the codebase - at this point they only exist since some backends require spellingfirst/lastasfirst_value/last_valuewhen used in a window function context (other backends aliasfirst/lastto these for nicer SQL UX).This PR:
FirstValue/LastValuetoibis/backends/sql/rewrites.pyto treat them as SQL-specific IR.First -> FirstValue/Last -> LastValuewindow function rewrites to always apply for all SQL backends, making our compilation more uniform here.