Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(exasol): add custom TimestampTruncate #8590

Merged
merged 1 commit into from
Mar 8, 2024
Merged

refactor(exasol): add custom TimestampTruncate #8590

merged 1 commit into from
Mar 8, 2024

Conversation

Nicoretti
Copy link
Contributor

Description of changes

Add custom TimestampTruncate for exasol in order to support week based truncation.

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep 'em coming!

@cpcloud cpcloud added this to the 9.0 milestone Mar 8, 2024
@cpcloud cpcloud added refactor Issues or PRs related to refactoring the codebase exasol Issues related to the exasol backend labels Mar 8, 2024
@cpcloud cpcloud enabled auto-merge (squash) March 8, 2024 10:31
auto-merge was automatically disabled March 8, 2024 10:33

Head branch was pushed to by a user without write access

@Nicoretti Nicoretti requested a review from cpcloud March 8, 2024 10:49
@Nicoretti
Copy link
Contributor Author

@cpcloud slightly reworked the function to make use of the base class implementation wherever possible.

@cpcloud cpcloud enabled auto-merge (squash) March 8, 2024 11:06
auto-merge was automatically disabled March 8, 2024 11:08

Head branch was pushed to by a user without write access

@cpcloud cpcloud enabled auto-merge (squash) March 8, 2024 11:23
@cpcloud cpcloud merged commit 66f12c3 into ibis-project:main Mar 8, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exasol Issues related to the exasol backend refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants