-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(sql): prevent sqlglot from extensive deepcopying every time we create a sqlglot object #8592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
556d73b
to
cba0d80
Compare
kszucs
commented
Mar 8, 2024
|
Hm, the failing tests seem to be exposing a bug in sqlglot. |
ec7f86f
to
005d609
Compare
d92e71a
to
cab3f87
Compare
…reate a sqlglot object
|
After |
kszucs
commented
Mar 12, 2024
cpcloud
approved these changes
Mar 13, 2024
|
@kszucs Feel free to merge whenever you're ready. |
|
Thanks for the mssql workaround! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still profiling and adding more
copy=Falseoptions, apparently it greatly improves the performance.According to profiling the recursive generation of sqlglot is still a bottleneck for big queries which cannot be fixed on the ibis side. There could be one option though to compile the fragments in a greedy fashion which are going to be cached by
Node.map()and inject those as arbitrary strings to other sqlglot expressions.The benchmark shows a pretty solid improvement:
Also measured the heap usage right after translation:
Now it uses 30% of the memory it used before. Apparently there are still a lot of sqlglot Literal objects around, looking into that.
fixes #8484