Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): improve error message raised on improper calls to array map or filter #8602

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

jcrist
Copy link
Member

@jcrist jcrist commented Mar 8, 2024

Fixes #8553, supersedes #8552.

We can't realistically catch the invalid use of deferred sin the original issue, but we can ensure that in the case the deferred resolves to something valid we raise a nice error message rather than whatever inspect.signature happens to raise.

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cpcloud cpcloud added this to the 9.0 milestone Mar 9, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis ux User experience related issues labels Mar 9, 2024
@cpcloud cpcloud merged commit 0236370 into ibis-project:main Mar 9, 2024
81 checks passed
@jcrist jcrist deleted the improve-map-filter-errors branch March 9, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis ux User experience related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: inner Deferred binds to wrong thing in Table.select(_.x.map(_.b))
2 participants