depr: deprecate and warn on legacy udf usage
#8617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops I forgot to add ` |
cpcloud
requested changes
Mar 11, 2024
ncclementi
force-pushed
the
udf-warn-deprecate
branch
from
247dd83
to
cc821ce
Compare
test: add pytests.warns to deprecated udfs chore: remove examples of deprecated udfs
ncclementi
force-pushed
the
udf-warn-deprecate
branch
from
7599a6e
to
cf3791c
Compare
cpcloud
added
refactor
cpcloud
changed the title
legacy udf usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds warnings for deprecation of
ibis.legacy.udfforv9.0. I'm not super sure about theinsteadmessage forelementwise, suggestions are welcomed.According to the issue, seems like we are not going to support
analyticandreductionon the new system, hence the empty comment oninstead