-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ir): support showing variable names used to create an expression in repr()
#8630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repr()
cpcloud
reviewed
Mar 12, 2024
b3dde3d
to
2bd5c6f
Compare
kszucs
commented
Mar 12, 2024
|
Requires a follow-up ticket to document this. |
cpcloud
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, but doesn't really work with IPython at the moment.
I'm a bit wary of testing this until we work out more of the kinks given how niche the feature is.
cpcloud
reviewed
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the following code:
instead of showing
now we can render the expression representation as
This removes one level of indirection when we inspect an expression. Also not just tables but value nodes assigned to local variables are shown.
Note that it has its limitation based on where
repr()is called, butibis.expr.format.prettynow accepts ascopeargument where the variable names can be passed.