fix(sql): look for CTEs under value expressions as well #8633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
force-pushed
the
value-ctes
branch
4 times, most recently
from
d96d71d
to
df5961c
Compare
|
Would this also address #8484? |
I doubt because there are no subqueries, it could if we artificially introduce subqueries to not repeat tedious value expressions. |
|
@kszucs Is this ready for review? |
1 task
Yes. I will add test cases for the relevant |
Turns out it won't resolve those since those subqueries don't occur more than once. |
cpcloud
approved these changes
Mar 14, 2024
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common table expressions haven't been extracted for subqueries because we stopped traversing once reaching any value expression.