Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add constants to width and height #8640

Merged
merged 5 commits into from
Mar 13, 2024
Merged

docs: add constants to width and height #8640

merged 5 commits into from
Mar 13, 2024

Conversation

raybellwaves
Copy link
Contributor

Fixes #8639

@github-actions GitHub Actions
Copy link
Contributor

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@raybellwaves raybellwaves changed the title DOC: add constants to width and height docs: add constants to width and height Mar 13, 2024
lostmygithubaccount
lostmygithubaccount previously requested changes Mar 13, 2024
View reviewed changes
Copy link
Member

@lostmygithubaccount lostmygithubaccount left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind also removing these lines to avoid any confusion?

edit: whoops I messed up, the lines in the code fold above that set the height and width

@lostmygithubaccount lostmygithubaccount added the docs Documentation related issues or PRs label Mar 13, 2024
@raybellwaves
Copy link
Contributor Author

raybellwaves commented Mar 13, 2024 •
edited
Loading

would you mind also removing these lines to avoid any confusion?

edit: whoops I messed up, the lines in the code fold above that set the height and width

Not sure if I follow.

Edit: sorry I missed #8639 (comment)

lostmygithubaccount
lostmygithubaccount reviewed Mar 13, 2024
View reviewed changes
docs/index.qmd Outdated Show resolved Hide resolved
@cpcloud cpcloud added the docs-preview Add this label to trigger a docs preview label Mar 13, 2024
@cpcloud cpcloud added this to the 9.0 milestone Mar 13, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Mar 13, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Mar 13, 2024

Docs preview: https://pr-8640-c1314043b7ff7ed5736f7355a56b0b745a016653--ibis-quarto.netlify.app

cpcloud
cpcloud approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cpcloud cpcloud dismissed lostmygithubaccount’s stale review March 13, 2024 11:12

The requested change was made

@cpcloud cpcloud merged commit 01b3f28 into ibis-project:main Mar 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

@lostmygithubaccount lostmygithubaccount Awaiting requested review from lostmygithubaccount

Assignees
No one assigned
Labels
docs Documentation related issues or PRs
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

docs: quick start at altair plot fails
3 participants
@raybellwaves @cpcloud @lostmygithubaccount