fix(polars): ensure t.select(col=scalar) results in len(t) rows
#8665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrist
force-pushed
the
fix-polars-scalar-project
branch
from
3da345c
to
6f0c36b
Compare
cpcloud
force-pushed
the
fix-polars-scalar-project
branch
from
6f0c36b
to
37d093b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously broadcasting a scalar as a column and then selecting only that column would result in only one row (rather than
len(t)rows). This fixes that bug and adds a test.Based on #8664, since this fixes a test in that PR too.