Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): support pandas 2.2 #8758

Merged
merged 4 commits into from
Apr 15, 2024
Merged

fix(deps): support pandas 2.2 #8758

merged 4 commits into from
Apr 15, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Mar 25, 2024 •
edited
Loading

Various fixes to support pandas 2.2.

Non-test-related changes:

  • Exasol: set the timezone to UTC; without this change the database results don't match pandas' results
  • Pandas + Dask: handle new timedelta units
  • SQLite: use a different method for computing epoch seconds; the existing method didn't match pandas' results
  • Data conversion: handle the fact that ValueError is now raised when trying to convert from naive -> timezone'd data

@cpcloud cpcloud added this to the 9.0 milestone Mar 25, 2024
@cpcloud cpcloud added pandas The pandas backend dependencies Issues or PRs related to dependencies labels Mar 25, 2024
@cpcloud cpcloud force-pushed the pandas-2.2 branch 3 times, most recently from 5ab4443 to 90f4129 Compare March 26, 2024 11:36
@cpcloud cpcloud force-pushed the pandas-2.2 branch 7 times, most recently from a4bac06 to f271b63 Compare April 12, 2024 11:18
@cpcloud cpcloud requested a review from kszucs April 12, 2024 11:52
kszucs
kszucs approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kszucs kszucs merged commit 4b476ba into ibis-project:main Apr 15, 2024
86 checks passed
@cpcloud cpcloud deleted the pandas-2.2 branch April 15, 2024 12:26
This was referenced Apr 15, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kszucs kszucs kszucs approved these changes

Assignees
No one assigned
Labels
dependencies Issues or PRs related to dependencies pandas The pandas backend
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @kszucs