Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clickhouse): avoid forcing UTC to allow connection to servers that do not allow it #8762

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Mar 25, 2024

Fixes the ability to connect to clickhouse playground. From this Zulip topic.

@cpcloud cpcloud added this to the 9.0 milestone Mar 25, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis clickhouse The ClickHouse backend labels Mar 25, 2024
@cpcloud cpcloud requested a review from gforsyth March 25, 2024 12:56
@cpcloud
Copy link
Member Author

cpcloud commented Mar 25, 2024

Manual testing:

In [1]: from ibis.interactive import *

In [2]: con = ibis.clickhouse.connect(
   ...:     host="clickpy-clickhouse.clickhouse.com", database="pypi", secure=True, user="play"
   ...: )

In [3]: con.list_tables()
Out[3]:
['countries',
 'countries_dict',
 'last_updated_dict',
 'projects',
 'pypi',
 'pypi_downloads',
 'pypi_downloads_by_version',
 'pypi_downloads_by_version_mv',
 'pypi_downloads_max_min',
 'pypi_downloads_max_min_mv',
 'pypi_downloads_mv',
 'pypi_downloads_per_day',
 'pypi_downloads_per_day_by_version',
 'pypi_downloads_per_day_by_version_by_country',
 'pypi_downloads_per_day_by_version_by_country_mv',
 'pypi_downloads_per_day_by_version_by_file_type',
 'pypi_downloads_per_day_by_version_by_file_type_mv',
 'pypi_downloads_per_day_by_version_by_installer_by_type',
 'pypi_downloads_per_day_by_version_by_installer_by_type_by_country',
 'pypi_downloads_per_day_by_version_by_installer_by_type_by_country_mv',
 'pypi_downloads_per_day_by_version_by_installer_by_type_mv',
 'pypi_downloads_per_day_by_version_by_python',
 'pypi_downloads_per_day_by_version_by_python_by_country',
 'pypi_downloads_per_day_by_version_by_python_by_country_mv',
 'pypi_downloads_per_day_by_version_by_python_mv',
 'pypi_downloads_per_day_by_version_by_system',
 'pypi_downloads_per_day_by_version_by_system_by_country',
 'pypi_downloads_per_day_by_version_by_system_by_country_mv',
 'pypi_downloads_per_day_by_version_by_system_mv',
 'pypi_downloads_per_day_by_version_mv',
 'pypi_downloads_per_day_mv',
 'pypi_downloads_per_month',
 'pypi_downloads_per_month_mv']

@cpcloud cpcloud enabled auto-merge (squash) March 25, 2024 13:20
@cpcloud cpcloud merged commit 52eeea9 into ibis-project:main Mar 25, 2024
170 checks passed
@cpcloud cpcloud deleted the remove-ch-timezone-setting branch March 25, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis clickhouse The ClickHouse backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants