Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ir): loosen the join integrity checks #8817

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented Mar 28, 2024

Enables us easier join chain rewrites since we don't need to maintain a monotonically increasing index for the join tables.

Resolves #8773

@kszucs kszucs force-pushed the loosen-join-integrity-checks branch from 9405f60 to ec864b0 Compare April 3, 2024 08:15
@kszucs kszucs requested a review from cpcloud April 3, 2024 08:15
ibis/expr/tests/test_newrels.py Outdated Show resolved Hide resolved
@kszucs kszucs force-pushed the loosen-join-integrity-checks branch from ec864b0 to e245404 Compare April 3, 2024 11:23
@kszucs kszucs force-pushed the loosen-join-integrity-checks branch from e245404 to 885c008 Compare April 3, 2024 11:24
@kszucs kszucs requested a review from cpcloud April 3, 2024 11:24
@cpcloud cpcloud merged commit 2bc903d into ibis-project:main Apr 3, 2024
85 checks passed
@cpcloud cpcloud added the refactor Issues or PRs related to refactoring the codebase label Apr 3, 2024
@cpcloud cpcloud added this to the 9.0 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(ir): loosen the ops.JoinChain integrity checks
2 participants