fix(risingwave): set implicit flush to true #8929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
force-pushed
the
risingwave_flush
branch
from
6d7ba2b
to
31e06e8
Compare
|
Friendly ping @KeXiangWang! |
KeXiangWang
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
The implementation LGTM. I think it's reasonable to set it to true by default, but it will increase the latency of write operations. I'm considering whether we can provide an interface for the Risingwave backend to set the value to false so that someone who cares more about write latency can have more choices.
cpcloud
added
risingwave
cpcloud
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8780
If we set this option then the table expression doesn't render until the transaction is complete.
I think this is a reasonable thing to do by default, but there may be
streaming-related side-effects that I'm not considering.
@KeXiangWang -- does this seem ok to you?