Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snowflake-snowpark): disable the reconnect method #8969

Merged

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Apr 15, 2024

It's not yet feasible to call reconnect with an Ibis Snowflake backend initialized from a Snowpark connection, so this PR disables that code path.

@cpcloud cpcloud added this to the 9.0 milestone Apr 15, 2024
@cpcloud cpcloud added tests Issues or PRs related to tests snowflake The Snowflake backend labels Apr 15, 2024
@cpcloud cpcloud changed the title test(snowflake-snowpark): skip reconnect test fix(snowflake-snowpark): disable the reconnect method Apr 15, 2024
@cpcloud cpcloud force-pushed the snowflake-snowpark-skip-reconnect-test branch from 1294a4c to 8cdeb80 Compare April 15, 2024 11:50
@cpcloud cpcloud force-pushed the snowflake-snowpark-skip-reconnect-test branch from 8cdeb80 to f6cc071 Compare April 15, 2024 11:50
@cpcloud cpcloud requested a review from kszucs April 15, 2024 11:50
@cpcloud cpcloud enabled auto-merge (squash) April 15, 2024 12:25
@cpcloud cpcloud merged commit e31eded into ibis-project:main Apr 15, 2024
84 checks passed
@cpcloud cpcloud deleted the snowflake-snowpark-skip-reconnect-test branch April 15, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
snowflake The Snowflake backend tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants