Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigquery): ensure session creation before creating temp tables #8976

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Apr 15, 2024

Fixes #8975.

@cpcloud cpcloud added this to the 9.0 milestone Apr 15, 2024
@cpcloud cpcloud added tests Issues or PRs related to tests bigquery The BigQuery backend labels Apr 15, 2024
@cpcloud cpcloud requested a review from gforsyth April 15, 2024 23:18
@cpcloud
Copy link
Member Author

cpcloud commented Apr 15, 2024

BigQuery tests are passing:

…/ibis on  fix-temp-bigquery is 📦 v8.0.0 via 🐍 v3.12.2 via ❄️   impure (ibis-3.12.2-env) took 15s
❯ pytest -m bigquery -n auto --dist loadgroup --snapshot-update -q
bringing up nodes...
.....xx...x.x...........x.....ssssssssssssssssssssss..x.xx.....x.xxx..x...x.....x......x.x...x....x...x..x....x..........x.......x..........x.........................x...x....x..... [  9%]
..xxx..x..........x.........x......x........x....x...........x....xx...................x......x.x............x......x.x...x...x...................................x.................. [ 19%]
...........................x.....................x......................................x......................x....................................s................ss.............. [ 29%]
......................................x............x..x..x...x.x.........x....x.....x....x.x.....x...x......x......x.....................x..........x.xx.x.......x..x....xx.....x.... [ 38%]
..x..x.............x.....x..xxx.s........x.......x..ssx..xs....xxxx..............x........................x.......x........x................................x.....s................x. [ 48%]
......x.x......x...xx.......x.............x..x................xxxx.xxxxxxxxxxxxxxxx.x.x.xx..x....x.x..........x....x....x....x....x................xx.............................x.. [ 58%]
........xx...xx....x..xx.x.x....x..xx...x....xx.........x..x..x.x.x.x..x....xx.x.x..x..x..x..xxxxx.xx.x.....x.xx....xx.x....x..x.......x...x.xx.xxx.x..xxxxxxxxx.xxxxxx.xxx.xxx...xxx [ 67%]
x..x.xxxxxx.xx.xx.xxxxxxx.xx.xxxxxxxxxxxxxx.xxxxxxx.xxxxxxxxxxxxxxxxxxxxxxxx.xxxxxxxxx...x.......x....x..x.x.x..xxx.......x.............x........x.......x.................x.x....... [ 77%]
..x.................................................................................................................................................x...............................x [ 87%]
...................................................................................................................................................................................... [ 96%]
...x......x..................................................                                                                                                                         [100%]
1528 passed, 30 skipped, 314 xfailed in 412.39s (0:06:52)

@kszucs kszucs merged commit 314abe4 into ibis-project:main Apr 16, 2024
88 checks passed
@cpcloud cpcloud deleted the fix-temp-bigquery branch April 16, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery The BigQuery backend tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Unable to create temporary table on bigquery
2 participants