feat(postgres): support loading tables with pgvector column types
#9037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have support for a bare `vector` type, but `pgvector` also has precision.
gforsyth
force-pushed
the
pgvector_type_support
branch
from
fbb4bf3
to
0679e02
Compare
cpcloud
reviewed
Apr 25, 2024
| FROM postgis/postgis:15-3.3-alpine | ||
| RUN apk add --no-cache postgresql15-plpython3 | ||
| COPY --from=pgvector-builder /usr/local/lib/postgresql/bitcode/vector.index.bc /usr/local/lib/postgresql/bitcode/vector.index.bc | ||
| COPY --from=pgvector-builder /usr/local/lib/postgresql/vector.so /usr/local/lib/postgresql/vector.so | ||
| COPY --from=pgvector-builder /usr/local/share/postgresql/extension /usr/local/share/postgresql/extension |
|
Also, sorry you had to fix this again 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9025
We have had support for a bare
vectortype for a while, butpgvectordefinestheir vector type with precision, like
vector(3)which was breaking our dtypeparsing.
I've opted to check here if the type starts with
vectorand treat all of those asdt.unknown.For testing this, I've added
pgvectorto the postgres dockerfile -- if that'stoo heavy, we can maybe mock up something in the
postgres.sqlfile? But itdoes compile reasonably quickly on my machine (~4 seconds).