feat(geo-duckdb): support casting binary to geometry #9062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
reviewed
Apr 26, 2024
ibis/backends/conftest.py
Outdated
Comment on lines
147
to
152
| "geo_wkb": ibis.schema( | ||
| { | ||
| "name": "string", | ||
| "geom": "binary", | ||
| } | ||
| ), |
There was a problem hiding this comment.
entries here are also expected to have a csv file in testing-data -- might be better off sticking this in the duckdb conftest.py for now.
cpcloud
requested changes
Apr 27, 2024
Add support to cast wkb to geometry type in duckdb backend chore: move geo_wkb table to duckdb conftest chore: fix test
cpcloud
approved these changes
Apr 29, 2024
cpcloud
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to cast wkb to geometry type in duckdb backend
Closes #8805
This PR: needs a data file, CI will fail until ibis-project/testing-data#8 gets merged