fix(pyspark): unwind catalog/database settings in same order they were set #9067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e set We set the catalog using a context manager, and we set the database also using a context manager. There is a weird edge case: set catalog to comms_media_dev (succeeds) set database to dart_extensions within comms_media_dev (succeeds) then we write the table, great! Now we try to change catalog and database back in reverse order and... set database to default (the previous value that we saved) within comms_media_dev (fails, you do not have permission to access that) set catalog back to spark_catalog (or previous value, but we never get here because of the previous error. So what we need to do is instead: set catalog set database write table set catalog back set database back It would be really great if spark would allow for setting both of these values at the same time, but that is apparently not a thing.
1 task
|
I forgot to include |
gforsyth
force-pushed
the
pyspark_catalog_horribleness
branch
from
567cbc0
to
bf52f9c
Compare
cpcloud
reviewed
Apr 30, 2024
cpcloud
approved these changes
Apr 30, 2024
|
@gforsyth Just a heads up this is now working for my use case (multiple catalogs). Thanks so much for all your help and definitely feel free to hit me up if you ever need help testing pyspark backend 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set the catalog using a context manager, and we set the database also
using a context manager. There is a weird edge case:
set catalog to comms_media_dev (succeeds)
set database to dart_extensions within comms_media_dev (succeeds)
then we write the table, great! Now we try to change catalog and database back in reverse order and...
set database to default (the previous value that we saved) within comms_media_dev (fails, you do not have permission to access that)
set catalog back to spark_catalog (or previous value, but we never get here because of the previous error.
So what we need to do is instead:
set catalog
set database
write table
set catalog back
set database back
It would be really great if spark would allow for setting both of these values at the same time, but that is apparently not a thing.
xref #9038