Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rework the homepage #9088

Merged
merged 22 commits into from
May 2, 2024

Conversation

lostmygithubaccount
Copy link
Member

Description of changes

This is a simple rework of the homepage. CSS/fancy things are ignored for now, but could be added in later. For now, this:

  • adds a codespace button in the getting started tutorial
  • small adjustment to sankey diagram (font size)
  • makes the Ibis homepage have some of the stuff from the GitHub README
  • explain a bit more and show some code examples
  • unhide the quickstart from buttons
  • other edits

Issues closed

#8856

@lostmygithubaccount
Copy link
Member Author

still should answer this, maybe:

Confidence Ibis is a well-supported, production-ready library

@lostmygithubaccount lostmygithubaccount added docs Documentation related issues or PRs docs-preview Add this label to trigger a docs preview labels Apr 30, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Apr 30, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Apr 30, 2024

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Apr 30, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Apr 30, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Apr 30, 2024

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Apr 30, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Apr 30, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Apr 30, 2024

@lostmygithubaccount
Copy link
Member Author

some passing feedback from JIm (noting for later):

  • rework titles/perhaps order to ensure portability comes across (i.e. not just fast local dataframes)
  • remove local/remote example, perhaps just prose for that, too complicated
  • remove quickstart
    • move some parts to getting started tutorial or other places
  • CTAs at the bottom instead (getting started tutorial; why ibis; etc)

docs/index.qmd Outdated Show resolved Hide resolved
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label May 1, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label May 1, 2024
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label May 1, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label May 1, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented May 1, 2024

@lostmygithubaccount
Copy link
Member Author

idk why the buttons at the bottom aren't full width, as they are locally. maybe scss stuff colliding? maybe if I add elsewhere

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label May 1, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label May 1, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented May 1, 2024

Docs preview: https://pr-9088-91a7da5d4eae99432dcc457ce801e5e6dd6623e3--ibis-quarto.netlify.app

@lostmygithubaccount lostmygithubaccount changed the title docs: rework the homepage [NO MERGE] docs: rework the homepage May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@lostmygithubaccount lostmygithubaccount changed the title [NO MERGE] docs: rework the homepage docs: rework the homepage May 2, 2024
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label May 2, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label May 2, 2024
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label May 2, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label May 2, 2024
@lostmygithubaccount lostmygithubaccount marked this pull request as ready for review May 2, 2024 00:51
@lostmygithubaccount
Copy link
Member Author

lostmygithubaccount commented May 2, 2024

before merging, should also check w/ the 3 people quoted that they're okay with it. made some light edits to the quotes

asked all 3 on Zulip -- cc: @mark-druffel @stereoF. not sure on Nick's GH handle

@ibis-docs-bot
Copy link

ibis-docs-bot bot commented May 2, 2024

@mark-druffel
Copy link

Small edit: my last name is spelled Druffel, not druffle ☺️

docs/index.qmd Outdated Show resolved Hide resolved
@cpcloud cpcloud added this to the 9.1 milestone May 2, 2024
@lostmygithubaccount
Copy link
Member Author

Small edit: my last name is spelled Druffel, not druffle ☺️

sorry about that, thanks for catching!

docs/index.qmd Outdated Show resolved Hide resolved
lostmygithubaccount and others added 3 commits May 2, 2024 12:01
Co-authored-by: nick <889427+shicholas@users.noreply.github.com>
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label May 2, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label May 2, 2024
@lostmygithubaccount lostmygithubaccount enabled auto-merge (squash) May 2, 2024 16:12
@lostmygithubaccount
Copy link
Member Author

thanks everyone! didn't get explicit approval from Daniel but given that quote is already one the website, will ask for forgiveness :)

@lostmygithubaccount lostmygithubaccount merged commit c68f9d4 into ibis-project:main May 2, 2024
19 checks passed
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented May 2, 2024

@pybokeh
Copy link

pybokeh commented May 20, 2024

Sorry, I missed your message Cody! @lostmygithubaccount The quote looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants