docs(descheming): move callout note outside of parameter description #9133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrist
approved these changes
May 6, 2024
Callouts inside of a parameter description aren't being rendered in the docs, so I've moved this callout into the main body of the docstring so it renders correctly. I've also added the same callout to the `read_postgres` method on the DuckDB backend, as postgres users may try to use `schema` in the hierarchical sense.
cpcloud
force-pushed
the
fix_schema_callouts
branch
from
5c47258
to
3e11781
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callouts inside of a parameter description aren't being rendered in the
docs, so I've moved this callout into the main body of the docstring so
it renders correctly.
I've also added the same callout to the
read_postgresmethod on theDuckDB backend, as postgres users may try to use
schemain thehierarchical sense.
xref #8712