fix(bigquery): quote all parts of table names #9141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
cpcloud
reviewed
May 7, 2024
cpcloud
reviewed
May 7, 2024
|
|
||
| for key in ("this", "db", "catalog"): | ||
| if (val := table.args[key]) is not None: | ||
| assert val.quoted |
There was a problem hiding this comment.
can we instead test the expected output as part of the test parameterization?
The BigQuery identifier quoting semantics are bonkers https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#identifiers my-table is OK, but not mydataset.my-table mytable-287 is OK, but not mytable-287a Just quote everything.
gforsyth
force-pushed
the
bigquery_location_quoting
branch
from
8e1902f
to
5c05192
Compare
|
running bigquery tests locally -- I suspect this may update a few snapshots |
cpcloud
approved these changes
May 7, 2024
cpcloud
added
bug
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BigQuery identifier quoting semantics are bonkers
https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#identifiers
my-table is OK, but not mydataset.my-table
mytable-287 is OK, but not mytable-287a
Just quote everything.
xref #8679