Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(duckdb): use existing table repr for settings view #9155

Merged
merged 3 commits into from
May 8, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented May 8, 2024

Fixes the repr of the duckdb backend settings property to be the table containing all settings

@cpcloud cpcloud requested a review from gforsyth May 8, 2024 11:43
@cpcloud cpcloud added this to the 9.1 milestone May 8, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis duckdb The DuckDB backend labels May 8, 2024
@gforsyth gforsyth merged commit 1892bfd into ibis-project:main May 8, 2024
86 checks passed
@gforsyth
Copy link
Member

gforsyth commented May 8, 2024

Nice!

@cpcloud cpcloud deleted the fix-duckdb-settings-repr branch May 8, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis duckdb The DuckDB backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants