fix(to_sql): use default backend for sql generation when set #9228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
right, snapshot test with a generated name... sigh. |
|
going to regenerate snapshots with a static name, just wanted to kill the CI jobs that hadn't failed yet. |
We weren't passing `use_default=True` when looking for backends in `to_sql` when no `dialect` was specified. This worked for nearly all cases, except when an expression was built from a `memtable`. A `memtable` doesn't have a specific backend, but if a user has set a default backend, we should assume that dialect for rendering sql (instead of our default of DuckDB sql)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't passing
use_default=Truewhen looking for backends into_sqlwhen nodialectwas specified. This worked for nearly allcases, except when an expression was built from a
memtable.A
memtabledoesn't have a specific backend, but if a user has set adefault backend, we should assume that dialect for rendering
sql (instead of our default of DuckDB sql)
Resolves #9227