fix(mysql): avoid creating any tables when using .sql()
#9363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
bug
cpcloud
force-pushed
the
mysql-dont-create-table-for-dot-sql
branch
2 times, most recently
from
906e4bf
to
042366c
Compare
|
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
cpcloud
changed the title
.sql().sql()
cpcloud
force-pushed
the
mysql-dont-create-table-for-dot-sql
branch
from
042366c
to
4b5a609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR fixes an issue with using
.sql()with MySQL in environments where theuser doesn't have permission to create tables.
Previously we created a temporary table with zero rows and then used that to
discover types of a query.
In this PR, I use the given zero-row
SELECTquery to get the types of the columnsusing
cursor.descriptionalong with some low level details of the MySQL protocol.Inferring types this way doesn't allow getting type information from ad-hoc
types that use plugins, like uuid or inet, so their physical type is used
(string in both those cases).
This seems like an acceptable tradeoff given that without this change
.sql()cannot be used in a whole class of deployments/environments.
Issues closed
Closes #9354.