Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trino): allow passing the auth keyword #9410

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 20, 2024

In Ibis 10, I will change the connect API here to just forward kwargs, but for now this change is backward compatible and can be shipped in a non-major release.

Closes #9409.

@cpcloud cpcloud added this to the 9.2 milestone Jun 20, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis trino The Trino backend labels Jun 20, 2024
@cpcloud cpcloud requested review from gforsyth and jcrist June 20, 2024 10:50
@cpcloud
Copy link
Member Author

cpcloud commented Jun 20, 2024

Actually, I'm going to deprecate password.

Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cpcloud cpcloud enabled auto-merge (squash) June 20, 2024 15:00
@cpcloud cpcloud merged commit 560ddf6 into ibis-project:main Jun 20, 2024
76 checks passed
@cpcloud cpcloud deleted the trino-auth branch June 20, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis trino The Trino backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem of authentication with JWTAuthentication and Trino
2 participants