fix(oracle, clickhouse): ensure port is captured in _from_url implementation
#9507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
reviewed
Jul 3, 2024
There was a problem hiding this comment.
Thanks for putting this in @grieve54706 !
One small request around checking that the port parsing is working as expected (and to contrast it to the behavior when the port is incorrect)
|
|
||
|
|
||
| def test_invalid_port(con): | ||
| port = 9999 |
There was a problem hiding this comment.
Can we add a successful connection using the correct port at the beginning of this test to show that the port is being correctly parsed?
There was a problem hiding this comment.
Nice idea. I will add a successful test case. Thanks.
gforsyth
changed the title
port is captured in Oracle and ClickHouse _from_url implementationport is captured in _from_url implementation
gforsyth
reviewed
Jul 3, 2024
Comment on lines
+89
to
+95
| port = 9999 | ||
| url = f"oracle://{ORACLE_USER}:{ORACLE_PASS}@{ORACLE_HOST}:{port}/IBIS_TESTING" | ||
| with pytest.raises( | ||
| oracledb.OperationalError, | ||
| match="DPY-6005: cannot connect to database", | ||
| ): | ||
| ibis.connect(url) |
There was a problem hiding this comment.
oops, same request here, too, re: adding a successful connection
There was a problem hiding this comment.
I think the test_from_url is enough proof. WDYT?
def test_from_url(con):
new_con = ibis.connect("oracle://ibis:ibis@localhost:1521/IBIS_TESTING")
assert new_con.list_tables()
grieve54706
force-pushed
the
bugfix/missing-port-in-connection-string
branch
4 times, most recently
from
cab3414
to
9b6d8d6
Compare
grieve54706
force-pushed
the
bugfix/missing-port-in-connection-string
branch
from
9b6d8d6
to
405d752
Compare
gforsyth
approved these changes
Jul 9, 2024
|
Thanks @gforsyth. Thank you for your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix oracle and clickhouse missing
portin_from_url.