feat(dtypes): fall back to dt.unknown for unknown types
#9567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had a number of issues where we haven't exposed a mapping to a particular (usually Postgres) dtype. We'll still have requests to provide useful mappings, depending on the upstream dtype, but this should prevent users being unable to even open a table because there's an unknown / user-defined dtype present in the table. To test, I've removed the special handling for the `vector` and `ts.vector` types that we were explicitly mapping to `dt.unknown`.
gforsyth
force-pushed
the
unknown_unknowns
branch
from
6ca6883
to
b0e1dc0
Compare
cpcloud
approved these changes
Jul 13, 2024
gforsyth
added a commit
that referenced
this pull request
Jul 13, 2024
)" This reverts commit 6e0b5f5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
We've had a number of issues where we haven't exposed a mapping to a
particular (usually Postgres) dtype.
We'll still have requests to provide useful mappings, depending on the
upstream dtype, but this should prevent users being unable to even open
a table because there's an unknown / user-defined dtype present in the
table.
To test, I've removed the special handling for the
vectorandts.vectortypes that we were explicitly mapping todt.unknown.xref #9511 -- we probably still want to pick a specific dtype to map the BIT type to so that the data are REPRd, but this will prevent load failures (there and elsewhere).