feat(api): support selectors in window function order_by and group_by
#9649
Conversation
cpcloud
added
feature
cpcloud
force-pushed
the
group-by-order-by-window-selectors
branch
from
0f0cca6
to
2d4a7ba
Compare
| if TYPE_CHECKING: | ||
| from collections.abc import Sequence | ||
|
|
||
| import ibis.expr.types as ir |
There was a problem hiding this comment.
I would prefer not to move the base selector class to ibis.common since it is tied to ir.Table.
I think Selectors could be viewed as another kind of deferred (or rather Resolver) producing a sequence of outputs and deferreds are decoupled from the ir.
There was a problem hiding this comment.
If I recall correctly even bind() would properly handle that, so refactoring selectors as Resolvers could simplify the codebase, but that should be done in a separate PR.
There was a problem hiding this comment.
I moved the class to avoid an import cycle and having it anywhere else didn't really fit.
If you have another suggestion that isn't to refactor the whole class :) I'm happy to hear it!
There was a problem hiding this comment.
Ohh, I wasn't aware of the import cycle.
cpcloud
force-pushed
the
group-by-order-by-window-selectors
branch
from
2d4a7ba
to
85faac8
Compare
| groupings: VarTuple[Union[str, Resolver, ops.Value]] = () | ||
| orderings: VarTuple[Union[str, Resolver, ops.SortKey]] = () | ||
| groupings: VarTuple[Union[str, Resolver, Selector, ops.Value]] = () | ||
| orderings: VarTuple[Union[str, Resolver, Selector, ops.SortKey]] = () |
There was a problem hiding this comment.
Since there's a bit of noise from dealing with the import cycle from using Selector at the top level of builders.py, I'm calling out that this is the change that enables use of a Selector in the group_by and order_by window APIs.
We're already calling Table.bind on these two fields in the appropriate place, we simply needed to allow them in the signature of this builder to allow them to get passed through the API.
cpcloud
force-pushed
the
group-by-order-by-window-selectors
branch
from
85faac8
to
60fa0b1
Compare
Support selectors in window function
group_byandorder_byarguments. Closes #9637.