Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mssql): remove sort key to keep order #9848

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

grieve54706
Copy link
Contributor

Description of changes

Iterate rows directly without sorting by key.

Issues closed

Resolves #9846

@cpcloud
Copy link
Member

cpcloud commented Aug 15, 2024

This isn't the correct way to fix the problem (which is definitely a problem!).

The code here was changed, but the sorted key was not updated to reflect the change.

We still need to sort by the column's id (an integer indicating its position).

Thank you for adding a test. I will push up the correct changes.

@cpcloud cpcloud force-pushed the bugfix/mssql-schema-type-order branch from 9489891 to c66a314 Compare August 15, 2024 14:08
@cpcloud cpcloud force-pushed the bugfix/mssql-schema-type-order branch from c66a314 to 6cacd3b Compare August 15, 2024 14:10
@cpcloud cpcloud added bug Incorrect behavior inside of ibis mssql The Microsoft SQL Server backend labels Aug 15, 2024
@cpcloud cpcloud force-pushed the bugfix/mssql-schema-type-order branch from b10ce7e to 3d0a882 Compare August 15, 2024 14:24
@cpcloud cpcloud enabled auto-merge (squash) August 15, 2024 14:26
@cpcloud cpcloud merged commit 3780a13 into ibis-project:main Aug 15, 2024
82 checks passed
@grieve54706 grieve54706 deleted the bugfix/mssql-schema-type-order branch August 16, 2024 02:31
@grieve54706
Copy link
Contributor Author

grieve54706 commented Aug 16, 2024

This isn't the correct way to fix the problem (which is definitely a problem!).

The code here was changed, but the sorted key was not updated to reflect the change.

We still need to sort by the column's id (an integer indicating its position).

Thank you for adding a test. I will push up the correct changes.

Hi @cpcloud, thank you for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis mssql The Microsoft SQL Server backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: mssql pandas data can't be converted by correct type
3 participants