feat(sql): load parsed but unsupported types as unknown #9868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a loose follow-up to #9576.
In that PR, I added support for falling back to
dt.unknownwhensqlglotfailed to parse a type string. In that case, it was usually handling things
like user-defined types in Postgres.
This is a related change, where we mark a dtype as
unknownifsqlglotdoesparse it correctly, but we don't have support for the dtype. The user can't
operate on the column in question, but at least the table will load.
A representative issue is loading a table in Clickhouse that has a
uint256columnIssues closed
xref #9861
Closes #9869.