From 11135df30711320bfef6598ba792314e6c7637ac Mon Sep 17 00:00:00 2001 From: Falk Zoll Date: Wed, 17 Jun 2020 11:58:52 +0200 Subject: [PATCH] Switch translation tests to 'it' as 'es' shows strange results. Switch the translation tests to 'it' as the up to now used 'es' now shows the englisch translation 'Hello' instead of the expected 'Hola'. This may get fixed in the future, then we can switch back again. --- tests/dat/actions/integration/testWatsonAction.swift | 4 ++-- tests/dat/actions/integration/testWatsonActionCodable.swift | 2 +- .../dat/actions/integration/testWatsonActionCodableSDK1.swift | 2 +- tests/dat/actions/integration/testWatsonActionSDK1.swift | 4 ++-- .../integration/CredentialsIBMSwiftActionWatsonTests.scala | 4 ++-- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/dat/actions/integration/testWatsonAction.swift b/tests/dat/actions/integration/testWatsonAction.swift index 67fde8a..38f562d 100644 --- a/tests/dat/actions/integration/testWatsonAction.swift +++ b/tests/dat/actions/integration/testWatsonAction.swift @@ -6,7 +6,7 @@ func main(args: [String:Any]) -> [String:Any] { let username = args["username"] as! String let password = args["password"] as! String let languageTranslator = LanguageTranslator(username: username, password: password, version: "2018-09-16") - let request = TranslateRequest(text: ["Hello"], source: "en", target: "es") + let request = TranslateRequest(text: ["Hello"], source: "en", target: "it") let failure = { (error: Error) in print(error) } dispatchGroup.enter() @@ -17,4 +17,4 @@ func main(args: [String:Any]) -> [String:Any] { } _ = dispatchGroup.wait(timeout: .distantFuture) return resp -} \ No newline at end of file +} diff --git a/tests/dat/actions/integration/testWatsonActionCodable.swift b/tests/dat/actions/integration/testWatsonActionCodable.swift index 616a60e..b962260 100644 --- a/tests/dat/actions/integration/testWatsonActionCodable.swift +++ b/tests/dat/actions/integration/testWatsonActionCodable.swift @@ -13,7 +13,7 @@ struct Output: Codable { } func main(param: Input, completion: @escaping (Output?, Error?) -> Void) -> Void { let languageTranslator = LanguageTranslator(username: param.username , password: param.password, version: "2018-09-16") - let request = TranslateRequest(text: ["Hello"], source: "en", target: "es") + let request = TranslateRequest(text: ["Hello"], source: "en", target: "it") let failure = {(error: Error) in print(" calling translate Error") print(error) diff --git a/tests/dat/actions/integration/testWatsonActionCodableSDK1.swift b/tests/dat/actions/integration/testWatsonActionCodableSDK1.swift index d0f1c53..f472b39 100644 --- a/tests/dat/actions/integration/testWatsonActionCodableSDK1.swift +++ b/tests/dat/actions/integration/testWatsonActionCodableSDK1.swift @@ -13,7 +13,7 @@ struct Output: Codable { } func main(param: Input, completion: @escaping (Output?, Error?) -> Void) -> Void { let languageTranslator = LanguageTranslator(username: param.username , password: param.password, version: "2018-09-16") - languageTranslator.translate(text: ["Hello"], source: "en", target: "es") { (response, error) in + languageTranslator.translate(text: ["Hello"], source: "en", target: "it") { (response, error) in if let error = error { print(error) return diff --git a/tests/dat/actions/integration/testWatsonActionSDK1.swift b/tests/dat/actions/integration/testWatsonActionSDK1.swift index 3bd19b5..c443461 100644 --- a/tests/dat/actions/integration/testWatsonActionSDK1.swift +++ b/tests/dat/actions/integration/testWatsonActionSDK1.swift @@ -8,7 +8,7 @@ func main(args: [String:Any]) -> [String:Any] { let languageTranslator = LanguageTranslator(username: username, password: password, version: "2018-09-16") - languageTranslator.translate(text: ["Hello"], source: "en", target: "es") { (response, error) in + languageTranslator.translate(text: ["Hello"], source: "en", target: "it" ) { (response, error) in if let error = error { print(error) return @@ -25,4 +25,4 @@ func main(args: [String:Any]) -> [String:Any] { _ = _whisk_semaphore.wait(timeout: .distantFuture) return resp -} \ No newline at end of file +} diff --git a/tests/src/test/scala/runtime/integration/CredentialsIBMSwiftActionWatsonTests.scala b/tests/src/test/scala/runtime/integration/CredentialsIBMSwiftActionWatsonTests.scala index 5811cdf..4634725 100644 --- a/tests/src/test/scala/runtime/integration/CredentialsIBMSwiftActionWatsonTests.scala +++ b/tests/src/test/scala/runtime/integration/CredentialsIBMSwiftActionWatsonTests.scala @@ -61,7 +61,7 @@ abstract class CredentialsIBMSwiftActionWatsonTests extends TestHelpers with Wsk withActivation(wsk.activation, wsk.action.invoke("testWatsonAction")) { activation => val response = activation.response response.result.get.fields.get("error") shouldBe empty - response.result.get.fields("translation") shouldBe JsString("hola") + response.result.get.fields("translation") shouldBe JsString("Ciao") } } @@ -81,7 +81,7 @@ abstract class CredentialsIBMSwiftActionWatsonTests extends TestHelpers with Wsk withActivation(wsk.activation, wsk.action.invoke("testWatsonActionCodable")) { activation => val response = activation.response response.result.get.fields.get("error") shouldBe empty - response.result.get.fields("translation") shouldBe JsString("hola") + response.result.get.fields("translation") shouldBe JsString("Ciao") } }