New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ui.injectScript to resolve a promise when script is loaded #1063

Closed
starpit opened this Issue Jul 29, 2018 · 1 comment

Comments

1 participant
@starpit
Member

starpit commented Jul 29, 2018

right now, the caller of injectScript has to do some manual polling; we can use the script's onload to support this directly

@starpit

This comment has been minimized.

Member

starpit commented Jul 30, 2018

buggy PR, we aren't resolving the promise the second time; test gap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment