Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing badges for actions not created inside the shell #972

Open
rabbah opened this issue May 23, 2018 · 6 comments
Open

missing badges for actions not created inside the shell #972

rabbah opened this issue May 23, 2018 · 6 comments

Comments

@rabbah
Copy link
Contributor

rabbah commented May 23, 2018

an action not created in the shell will not generate badges:

create a java action in the shell:
action create j1 ~/projects/openwhisk/tests/dat/actions/helloJava.jar --main m

screen shot 2018-05-23 at 8 07 59 am

but create the same action from the command line and the rendering is different for

screen shot 2018-05-23 at 8 09 27 am

  • missing badge is due to the lack of annotation on the action that the shell generates
  • different message and font
@starpit
Copy link
Member

starpit commented May 23, 2018

yup, we cannot know that the action is a jar action without some client side help. we could try to interpret the binary blob as any number of types (zip, jar, etc.), and see which works, i suppose.

re: the difference in the body, this is more easily fixable.

@rabbah
Copy link
Contributor Author

rabbah commented May 23, 2018

The kind and exec info isn’t enough?

ie kind java and binary it’s a jar

@starpit
Copy link
Member

starpit commented May 23, 2018

for java, perhaps

@rabbah
Copy link
Contributor Author

rabbah commented May 23, 2018

Fair - for java it’s obvious. For the others it may not be clear whether zip or just binary.

@rabbah
Copy link
Contributor Author

rabbah commented May 23, 2018

We could augment the cli to add the same annotation... wdyt?

@starpit
Copy link
Member

starpit commented May 23, 2018

i think this could be valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants