New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure there's only one request per topic per consumer instance out at a given time #3

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@kauffecup

kauffecup commented Jan 13, 2016

Add _topicGetMap to ConsumerInstance. Every time ConsumerInstance.get() is issued - keep track of the promise for that topic. If a new get is issued for the same topic, return the existing promise. Do necessary cleanup when request is finished.

Without this, you get errors that look like:

[Error: Request returned status code 500 but it was not in the accepted list. The
REST API responded with the following message: Another request is in progress
for consumer "test:test1". Request may be retried when response is received for
the previous request.]
Ensure there's only one request per topic per consumer instance out a…
…t a given time

Add `_topicGetMap` to ConsumerInstance. Every time `ConsumerInstance.get()` is issued - keep track of the promise for that topic. If a new get is issued for the same topic, return the existing promise. Do necessary cleanup when request is finished
@niall-weedon

This comment has been minimized.

Show comment
Hide comment
@niall-weedon

niall-weedon Mar 17, 2016

Contributor

Hi @kauffecup, thanks for your contribution. We've merged your changes with our private repository - expect to see your changes in the public repository soon!

Contributor

niall-weedon commented Mar 17, 2016

Hi @kauffecup, thanks for your contribution. We've merged your changes with our private repository - expect to see your changes in the public repository soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment