{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":195868401,"defaultBranch":"1060","name":"bmcweb","ownerLogin":"ibm-openbmc","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2019-07-08T18:45:17.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/41923445?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1721142444.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"a33fa9a4d1528126ba92b9290915811ef1132201","ref":"refs/heads/1060.10","pushedAt":"2024-07-16T15:07:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Remove sessions on user password update (#978)\n\nWhen a user's password is changed, existing Redfish sessions for that\r\nuser, created with the old password, continue to work.\r\n\r\nAs per OWASP session management, \"The session ID must be renewed or\r\nregenerated by the web application after any privilege level change\r\nwithin the associated user session... Common scenarios to consider\r\ninclude; password changes, permission changes, or switching from a\r\nregular user role to an administrator role within the web application.\"\r\n[1] https://cheatsheetseries.owasp.org/cheatsheets/Session_Management_Cheat_Sheet.html\r\n\r\nThis commit removes existing user sessions when the user's password is\r\nchanged. This commit leaves the current session in place though a new\r\nremoveSessionsByUsernameExceptSession().\r\n\r\nThis commit doesn't completely get us fully to what owasp says but is a\r\nstart.\r\n\r\nTested:\r\nCreate some users:\r\n```\r\ncurl -k -v -X POST -H \"Content-Type: application/json\" \\\r\nhttps://$bmc/redfish/v1/AccountService/Accounts/ -d \\\r\n'{\"UserName\":\"testadminuser\",\"Password\":\"<password>\",\"RoleId\":\"Administrator\",\"Enabled\":true}'\r\n```\r\n\r\nUsing basic auth was able to update own password and another user's\r\npassword.\r\n\r\nUsing token auth, verified the current session did not get deleted but\r\nother sessions from that user did.\r\n\r\n```\r\ncurl -k -H \"Content-Type: application/json\" -X POST -D headers.txt \\\r\nhttps://${bmc}/redfish/v1/SessionService/Sessions -d \\\r\n'{\"UserName\":\"testadminuser\", \"Password\":\"<password>\"}'\r\n```\r\n\r\n```\r\ncurl -k -v -X PATCH -H \"X-Auth-Token: $token\" \\\r\n-H \"Content-Type:application/json\" \\\r\nhttps://$bmc/redfish/v1/AccountService/Accounts/testadminuser \\\r\n-d '{\"Password\":\"<password>\"}'\r\n```\r\n\r\nVerified when changing another user's password all sessions were\r\ndropped.\r\n\r\nChange-Id: I4de60b84964a6b29c021dc3a2bece9ed4bc09eac\r\n\r\nSigned-off-by: Ravi Teja <raviteja28031990@gmail.com>","shortMessageHtmlLink":"Remove sessions on user password update (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2306156968\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/978\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/978/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/978\">#978</a>)"}},{"before":"3cab6108383fb8e020aa142df4e4d5d7d5729e4f","after":"1bcc02bec5b6631bbaca98b60bd00c77933777a8","ref":"refs/heads/1050","pushedAt":"2024-07-16T14:47:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Software: Add LowestSupportedVersion (#1012)\n\nA Minimum Version interface was added.[1] This is the minimum software\nversion that a component must have to operate. Like other interfaces it\nis optional. MinimumVersion maps to Redfish's LowestSupportedVersion.[2]\n\n\"LowestSupportedVersion\": {\n    \"description\": \"The lowest supported version of this software.\",\n    \"longDescription\": \"This property shall represent the lowest\nsupported version of this software.  This string is formatted using the\nsame format used for the `Version` property.\",\n    \"readonly\": true,\n    \"type\": [\n        \"string\",\n        \"null\"\n    ],\n    \"versionAdded\": \"v1_1_0\"\n\nphosphor-bmc-code-mgmt has support for minimum version.[3]\n\nphosphor-bmc-code-mgmt logs a Software Incompatible[4] error if this\nminimum version is not met. Mapping this error to a Redfish error is\nnot done here but could be added later.\n\nThis assumes the D-Bus path is /xyz/openbmc_project/software. This is\nwhere phosphor-bmc-code-mgmt put it. We assume D-Bus Paths like\n/xyz/openbmc_project/software/ + $id already.\n\n[1]: https://github.com/openbmc/phosphor-dbus-interfaces/commit/9012243e543abdc5851b7e878c17c991b2a2a8b7\n[2]: https://redfish.dmtf.org/schemas/v1/SoftwareInventory.v1_10_2.json\n[3]: https://github.com/openbmc/phosphor-bmc-code-mgmt/blob/85c71a13e0938cc4d36caf6b8e735e9740b2e351/meson.options#L100\n[4]: https://github.com/openbmc/phosphor-dbus-interfaces/blob/1c140b9766a15d1cbb8546fa02d5050d772a171d/yaml/xyz/openbmc_project/Software/Version.errors.yaml#L1\n\nTested: Using an IBM p10bmc see:\n{\n\"@odata.id\": \"/redfish/v1/UpdateService/FirmwareInventory/788d20be\",\n\"@odata.type\": \"#SoftwareInventory.v1_1_0.SoftwareInventory\",\n\"Description\": \"BMC image\",\n...\n\"LowestSupportedVersion\": \"fw1020.00-39.1\",\n...\n\nThe Redfish Validator has no new errors.\n\nChange-Id: I17e6d64c86a7d6312726783425101775a959dc04\n\nSigned-off-by: Gunnar Mills <gmills@us.ibm.com>","shortMessageHtmlLink":"Software: Add LowestSupportedVersion (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2363046744\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1012\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1012/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1012\">#1012</a>)"}},{"before":null,"after":"3cab6108383fb8e020aa142df4e4d5d7d5729e4f","ref":"refs/heads/1050.20","pushedAt":"2024-07-16T14:34:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"RedfishEvents GHE: Enable TLS1.2 in http client (#1023)","shortMessageHtmlLink":"RedfishEvents GHE: Enable TLS1.2 in http client (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2410274411\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1023\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1023/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1023\">#1023</a>)"}},{"before":"4dd24b8296bef1432945c3c87931f6120fd58913","after":"3cab6108383fb8e020aa142df4e4d5d7d5729e4f","ref":"refs/heads/1050","pushedAt":"2024-07-16T14:11:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"RedfishEvents GHE: Enable TLS1.2 in http client (#1023)","shortMessageHtmlLink":"RedfishEvents GHE: Enable TLS1.2 in http client (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2410274411\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1023\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1023/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1023\">#1023</a>)"}},{"before":"9e4fb79dc356d1e4d17df166e1346e719605d804","after":"1f75a6621cdaefc024c18fac2a958cdfa846f529","ref":"refs/heads/1060","pushedAt":"2024-07-16T13:47:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Software: Add LowestSupportedVersion (#1012)\n\nA Minimum Version interface was added.[1] This is the minimum software\r\nversion that a component must have to operate. Like other interfaces it\r\nis optional. MinimumVersion maps to Redfish's LowestSupportedVersion.[2]\r\n\r\n\"LowestSupportedVersion\": {\r\n    \"description\": \"The lowest supported version of this software.\",\r\n    \"longDescription\": \"This property shall represent the lowest\r\nsupported version of this software.  This string is formatted using the\r\nsame format used for the `Version` property.\",\r\n    \"readonly\": true,\r\n    \"type\": [\r\n        \"string\",\r\n        \"null\"\r\n    ],\r\n    \"versionAdded\": \"v1_1_0\"\r\n\r\nphosphor-bmc-code-mgmt has support for minimum version.[3]\r\n\r\nphosphor-bmc-code-mgmt logs a Software Incompatible[4] error if this\r\nminimum version is not met. Mapping this error to a Redfish error is\r\nnot done here but could be added later.\r\n\r\nThis assumes the D-Bus path is /xyz/openbmc_project/software. This is\r\nwhere phosphor-bmc-code-mgmt put it. We assume D-Bus Paths like\r\n/xyz/openbmc_project/software/ + $id already.\r\n\r\n[1]: https://github.com/openbmc/phosphor-dbus-interfaces/commit/9012243e543abdc5851b7e878c17c991b2a2a8b7\r\n[2]: https://redfish.dmtf.org/schemas/v1/SoftwareInventory.v1_10_2.json\r\n[3]: https://github.com/openbmc/phosphor-bmc-code-mgmt/blob/85c71a13e0938cc4d36caf6b8e735e9740b2e351/meson.options#L100\r\n[4]: https://github.com/openbmc/phosphor-dbus-interfaces/blob/1c140b9766a15d1cbb8546fa02d5050d772a171d/yaml/xyz/openbmc_project/Software/Version.errors.yaml#L1\r\n\r\nTested: Using an IBM p10bmc see:\r\n{\r\n\"@odata.id\": \"/redfish/v1/UpdateService/FirmwareInventory/788d20be\",\r\n\"@odata.type\": \"#SoftwareInventory.v1_1_0.SoftwareInventory\",\r\n\"Description\": \"BMC image\",\r\n...\r\n\"LowestSupportedVersion\": \"fw1020.00-39.1\",\r\n...\r\n\r\nThe Redfish Validator has no new errors.\r\n\r\nChange-Id: I17e6d64c86a7d6312726783425101775a959dc04\r\n\r\nSigned-off-by: Gunnar Mills <gmills@us.ibm.com>","shortMessageHtmlLink":"Software: Add LowestSupportedVersion (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2363046744\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1012\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1012/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1012\">#1012</a>)"}},{"before":"c7670768e31373c05aedffaafdb200533f35c1c3","after":"dd03cf82a75f113d3dfb0c1aae399e701cf347d8","ref":"refs/heads/1110","pushedAt":"2024-07-16T13:46:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Software: Add LowestSupportedVersion (#998)\n\nA Minimum Version interface was added.[1] This is the minimum software\r\nversion that a component must have to operate. Like other interfaces it\r\nis optional. MinimumVersion maps to Redfish's LowestSupportedVersion.[2]\r\n\r\n\"LowestSupportedVersion\": {\r\n    \"description\": \"The lowest supported version of this software.\",\r\n    \"longDescription\": \"This property shall represent the lowest\r\nsupported version of this software.  This string is formatted using the\r\nsame format used for the `Version` property.\",\r\n    \"readonly\": true,\r\n    \"type\": [\r\n        \"string\",\r\n        \"null\"\r\n    ],\r\n    \"versionAdded\": \"v1_1_0\"\r\n\r\nphosphor-bmc-code-mgmt has support for minimum version.[3]\r\n\r\nphosphor-bmc-code-mgmt logs a Software Incompatible[4] error if this\r\nminimum version is not met. Mapping this error to a Redfish error is\r\nnot done here but could be added later.\r\n\r\nThis assumes the D-Bus path is /xyz/openbmc_project/software/$id.\r\n\r\nphosphor-bmc-code-mgmt move it under $id at 72323[5]. We assume D-Bus\r\nPath /xyz/openbmc_project/software/ + $id already.\r\n\r\n[1]: https://github.com/openbmc/phosphor-dbus-interfaces/commit/9012243e543abdc5851b7e878c17c991b2a2a8b7\r\n[2]: https://redfish.dmtf.org/schemas/v1/SoftwareInventory.v1_10_2.json\r\n[3]: https://github.com/openbmc/phosphor-bmc-code-mgmt/blob/85c71a13e0938cc4d36caf6b8e735e9740b2e351/meson.options#L100\r\n[4]: https://github.com/openbmc/phosphor-dbus-interfaces/blob/1c140b9766a15d1cbb8546fa02d5050d772a171d/yaml/xyz/openbmc_project/Software/Version.errors.yaml#L1\r\n\r\nTested: Using an IBM p10bmc see:\r\n{\r\n\"@odata.id\": \"/redfish/v1/UpdateService/FirmwareInventory/788d20be\",\r\n\"@odata.type\": \"#SoftwareInventory.v1_1_0.SoftwareInventory\",\r\n\"Description\": \"BMC image\",\r\n...\r\n\"LowestSupportedVersion\": \"fw1020.00-39.1\",\r\n...\r\n\r\nThe Redfish Validator has no new errors.\r\n\r\nChange-Id: I17e6d64c86a7d6312726783425101775a959dc04\r\n\r\nSigned-off-by: Gunnar Mills <gmills@us.ibm.com>","shortMessageHtmlLink":"Software: Add LowestSupportedVersion (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2347268054\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/998\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/998/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/998\">#998</a>)"}},{"before":"d690822cb0aca2d0e339f08215f3306d2ba6791b","after":"c7670768e31373c05aedffaafdb200533f35c1c3","ref":"refs/heads/1110","pushedAt":"2024-07-15T15:29:12.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Audit Log: Use named fields for log entries (#1020)\n\nThe JSON file created by phosphor-auditlog now uses named fields for the\r\nexpected message parameters. It also no longer knows about the message\r\nregistry message. Adjust bmcweb to build the message from the expected\r\nJSON fields.\r\n\r\nTested:\r\n - Verified Redfish response same after change.\r\n - Redfish Validator passed.\r\n\r\nSigned-off-by: Janet Adkins <janeta@us.ibm.com>","shortMessageHtmlLink":"Audit Log: Use named fields for log entries (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2404194485\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1020\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1020/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1020\">#1020</a>)"}},{"before":"23399f25ca56788409b1b77f3e91687878fdbadc","after":"d690822cb0aca2d0e339f08215f3306d2ba6791b","ref":"refs/heads/1110","pushedAt":"2024-07-15T14:01:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Show hypervisor path on GET of Systems collection (#1021)\n\nRedfish GET on `/redfish/v1/Systems` is missing to show the hypervisor\r\nresource in its members list, even though hypervisor is available.\r\nThis commit fixes missing hypervisor resource in a GET response on\r\nSystems collection. The `Members@odata.count` is retrieved as `uint64_t`\r\npointer. But the Json library might store this value as \"int\" or\r\n\"size_t\". Therefore, directly casting it to uint64_t* might not work\r\nas expected.\r\n\r\nTested By:\r\nVerified \"GET https://${bmc}/redfish/v1/Systems\" returns the hypervisor\r\nresource\r\n\r\nChange-Id: If8713fc70663cf72cc555f695b8f4ec6547215a2\r\n\r\nSigned-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>","shortMessageHtmlLink":"Show hypervisor path on GET of Systems collection (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2406213524\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1021\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1021/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1021\">#1021</a>)"}},{"before":"51aaf0bbcaca0ad5d9cd638dce18ef926fed3f89","after":"23399f25ca56788409b1b77f3e91687878fdbadc","ref":"refs/heads/1110","pushedAt":"2024-07-15T13:32:22.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Util api to fetch pretty name for assemblies (#858)\n\nThis commit implements change to use util api to fetch prettyName\r\nproperty for any given assembly and publish it as \"Name\" in\r\nassembly schema.\r\n\r\nIn case prettyName is blank for that FRU, then last part of the\r\nobject path will be used to populate assembly name.\r\n\r\nValidator executed with no new errors.\r\n\r\nSigned-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>\r\nCo-authored-by: Sunny Srivastava <sunnsr25@in.ibm.com>","shortMessageHtmlLink":"Util api to fetch pretty name for assemblies (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2195314365\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/858\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/858/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/858\">#858</a>)"}},{"before":"148abc04d39ed3b09d870d094dab3bc8631b89f9","after":"4dd24b8296bef1432945c3c87931f6120fd58913","ref":"refs/heads/1050","pushedAt":"2024-07-10T16:49:39.000Z","pushType":"pr_merge","commitsCount":4,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Merge pull request #1018 from asmithakarun/noConnectionIssueFix\n\nNo connection issue fix","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2397296652\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1018\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1018/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1018\">#1018</a> from asmithakarun/noConnectionIssueFix"}},{"before":"2daa88d13942df2af7974d709e234983ff74f679","after":"51aaf0bbcaca0ad5d9cd638dce18ef926fed3f89","ref":"refs/heads/1110","pushedAt":"2024-07-09T13:57:18.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Fix BIOS attributes Patch operation (#1019)","shortMessageHtmlLink":"Fix BIOS attributes Patch operation (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2397854505\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1019\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1019/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1019\">#1019</a>)"}},{"before":"1e0b3a464615afda76c944ff02f3d6d72cba0ab8","after":"2daa88d13942df2af7974d709e234983ff74f679","ref":"refs/heads/1110","pushedAt":"2024-07-03T16:19:26.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Merge pull request #1017 from baemyung/1110-Fix-Validator-Warnings-On-OemSchemas\n\n1110: Fix Validator Warning on Oem Schemas","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2382345325\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1017\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1017/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1017\">#1017</a> from baemyung/1110-Fix-Validator-Warnings-On…"}},{"before":"3bd202e4723e1a4a0a94f2062fd0cc25e82b32e9","after":"1e0b3a464615afda76c944ff02f3d6d72cba0ab8","ref":"refs/heads/1110","pushedAt":"2024-06-27T16:16:16.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"anoo1","name":"Adriana Kobylak","path":"/anoo1","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9052527?s=80&v=4"},"commit":{"message":"Fix Handling of BiosAttributeRegistry (#1016)\n\nRedfish Service Validator is failing like this.\r\n```\r\n1 failGet errors in /redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry\r\n1 fails errors in /redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry\r\nERROR - URI did not return resource /redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry\r\n```\r\n\r\nIt can also be verified by doing this.\r\n```\r\ncurl -k -X GET https://${bmc}/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry\r\n{\r\n  \"error\": {\r\n    \"code\": \"Base.1.16.0.ResourceNotFound\",\r\n    \"message\": \"The requested resource of type MessageRegistryFile named 'BiosAttributeRegistry' was not found.\"\r\n```\r\n\r\nIt is because bmcweb does not handle the overlapping routes with\r\n- `/redfish/v1/Registries/<str>/<str>`\r\n- `/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry`\r\n\r\nIn fact, such routing logic worked before although it is not by intentional\r\ndesign, but it is no longer supported [1][2][3].\r\n\r\nSo, I've modified the logic to handle `BiosAttributeRegistry` so that\r\nit is routed from `/redfish/v1/Registries/<str>/<str>`\r\n\r\nTested:\r\n- Success on\r\n  `curl -k -X GET https://${bmc}/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry`\r\n\r\n- Redfish Service Validaor passes on /redfish/v1/Registries/\r\n\r\n[1] https://discord.com/channels/775381525260664832/1255570841568153702\r\n[2] https://discord.com/channels/775381525260664832/855566794994221117/1255524700654927953\r\n[3] https://discord.com/channels/775381525260664832/855566794994221117/1255526516612137040\r\n\r\nSigned-off-by: Myung Bae <myungbae@us.ibm.com>","shortMessageHtmlLink":"Fix Handling of BiosAttributeRegistry (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2376512086\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1016\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1016/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1016\">#1016</a>)"}},{"before":"b2ae81297b96881ed3b70baf00756e1d7d365c8f","after":"3bd202e4723e1a4a0a94f2062fd0cc25e82b32e9","ref":"refs/heads/1110","pushedAt":"2024-06-27T16:15:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"anoo1","name":"Adriana Kobylak","path":"/anoo1","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9052527?s=80&v=4"},"commit":{"message":"LogEntry: HW-Isolation: Removed the Resolved property (#341) (#1006)\n\n* LogEntry: HW-Isolation: Removed the Resolved property (#341)\r\n\r\n- The backend application is not going to maintain the Resolved\r\n  D-Bus entry because the resolved hardware isolation record slot\r\n  might be reused for the new record so it won't be accurate always.\r\n\r\n- So, In the Redfish also, we can drop the Resolved property while\r\n  listing the hardware isolation records.\r\n\r\nTested:\r\n\r\n- Verified by listing the hardware isolation records in the Redfish.\r\n```\r\ncurl -k -H \"X-Auth-Token: $bmc_token\" -X GET https://${bmc}/redfish/v1/ \\\r\n            Systems/system/LogServices/HardwareIsolation/Entries/1\r\n{\r\n  \"@odata.id\": \"/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/1\",\r\n  \"@odata.type\": \"#LogEntry.v1_9_0.LogEntry\",\r\n  \"Created\": \"2022-05-05T11:39:25+00:00\",\r\n  \"EntryType\": \"Event\",\r\n  \"Id\": \"1\",\r\n  \"Links\": {\r\n    \"OriginOfCondition\": {\r\n      \"@odata.id\": \"/redfish/v1/Systems/system/Memory/dimm0\"\r\n    }\r\n  },\r\n  \"Message\": \"Memory DIMM\",\r\n  \"Name\": \"Hardware Isolation Entry\",\r\n  \"Severity\": \"Warning\"\r\n}\r\n```\r\n\r\nSigned-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>\r\n\r\n* HW-Isolation: Map Manual error message to OK in entry message (#405) (#637)\r\n\r\nWhen PEL's with guard entry are deleted the severity type of guard record\r\nchanged from Predictive to Manual in Deconfiguration records page.\r\n\r\nRedfish severity \"Warning\" is translated to either \"Predictive/Manual\" in\r\nGUI. GUI marks the guard record as \"Manual\" if associated errorlog entry\r\nobject is not found.\r\n\r\nWhen a PEL is deleted associated error log object is deleted and GUI\r\nshould not treat the associated guard records as \"Manual\"\r\n\r\nNow using severity \"OK\" from the redfish schema to specify manually\r\ncreated guard records.\r\n\r\nSigned-off-by: Marri Devender Rao <devenrao@in.ibm.com>\r\n\r\n* Using sdbusplus::asio::getProperty\r\n\r\nUpdate the code to use safer and better wrapper sdbusplus::asio::getProperty\r\n instead of calling \"Get\" directly\r\n\r\nSigned-off-by: Deepa Karthikeyan <deepakala.karthikeyan@ibm.com>\r\n\r\n* Using sdbusplus::asio::getAllProperties\r\n\r\nUse the wrapper getAllProperties that is safer and cleaner in place of \"GetAll\"\r\n\r\nSigned-off-by: Deepa Karthikeyan <deepakala.karthikeyan@ibm.com>\r\n\r\n---------\r\n\r\nSigned-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>\r\nSigned-off-by: Marri Devender Rao <devenrao@in.ibm.com>\r\nSigned-off-by: Deepa Karthikeyan <deepakala.karthikeyan@ibm.com>\r\nCo-authored-by: Ramesh Iyyar <50703193+RameshIyyar@users.noreply.github.com>","shortMessageHtmlLink":"LogEntry: HW-Isolation: Removed the Resolved property (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1226604288\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/341\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/341/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/341\">#341</a>) (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2361400097\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1006\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1006/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1006\">#1006</a>)"}},{"before":"c9eca2266d64349b510504c09abcf5b29d723a94","after":"b2ae81297b96881ed3b70baf00756e1d7d365c8f","ref":"refs/heads/1110","pushedAt":"2024-06-26T14:19:39.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Revert \"Fix regression in metadata\" (#1015)\n\nThis reverts commit 093eebecf9c395aff3543b8252e2794e51530e59.","shortMessageHtmlLink":"Revert \"Fix regression in metadata\" (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2373615942\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1015\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1015/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1015\">#1015</a>)"}},{"before":"98eeee4d2d04d32740e432b2baf459455f3c9d02","after":"c9eca2266d64349b510504c09abcf5b29d723a94","ref":"refs/heads/1110","pushedAt":"2024-06-21T19:12:48.000Z","pushType":"pr_merge","commitsCount":5,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Merge pull request #1013 from gtmills/bump-schemas-base-registry\n\nBump schemas and base registry","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2363194093\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1013\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1013/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1013\">#1013</a> from gtmills/bump-schemas-base-registry"}},{"before":"857c0861176bf3eff324169be3b5271cc4d16011","after":"98eeee4d2d04d32740e432b2baf459455f3c9d02","ref":"refs/heads/1110","pushedAt":"2024-06-20T14:07:18.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Fix the BaseBIOSTable according to upstream schema (#1009)\n\nCo-authored-by: cmjishnu <cmjishnu@gfwa166.aus.stglabs.ibm.com>","shortMessageHtmlLink":"Fix the BaseBIOSTable according to upstream schema (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2362320167\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1009\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1009/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1009\">#1009</a>)"}},{"before":"f7d42a9a4e1ec1fe98218ef14a2d068f6ab83c6e","after":"857c0861176bf3eff324169be3b5271cc4d16011","ref":"refs/heads/1110","pushedAt":"2024-06-20T14:02:18.000Z","pushType":"pr_merge","commitsCount":8,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Merge pull request #1011 from baemyung/1110-generate-metadata-at-runtime\n\n1110: sync-up upstream: generate metadata at runtime","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2362689095\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1011\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1011/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1011\">#1011</a> from baemyung/1110-generate-metadata-at-runtime"}},{"before":"4ebade1c2023f00d7e1b75e0ba49e7b018aadc62","after":"f7d42a9a4e1ec1fe98218ef14a2d068f6ab83c6e","ref":"refs/heads/1110","pushedAt":"2024-06-19T18:00:55.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Allow patching AccountTypes (#1010)\n\n* Allow patching AccountTypes\r\n\r\nAllow PATCHing the ManagerAccount AccountTypes property.\r\n\r\nTested: compiles\r\n\r\nChange-Id: I4539d8d7127c8143e205b484ba9cfbbec9e1615d\r\nSigned-off-by: Joseph Reynolds <joseph.reynolds1@ibm.com>\r\n\r\n* clang format change\r\n\r\nChange-Id: I3c78d1b779a5a2b504f0c2e42946848067943240\r\nSigned-off-by: Joseph Reynolds <joseph.reynolds1@ibm.com>\r\n\r\n---------\r\n\r\nSigned-off-by: Joseph Reynolds <joseph.reynolds1@ibm.com>","shortMessageHtmlLink":"Allow patching AccountTypes (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2362644000\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1010\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1010/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1010\">#1010</a>)"}},{"before":"d4c170c49f6cbe099db937c9b0a8dcda648873dc","after":"4ebade1c2023f00d7e1b75e0ba49e7b018aadc62","ref":"refs/heads/1110","pushedAt":"2024-06-18T17:00:43.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Merge pull request #1001 from deepakala-k/ResourceCannotBeDeleted_others\n\nResource cannot be deleted others","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2350612042\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1001\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1001/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1001\">#1001</a> from deepakala-k/ResourceCannotBeDeleted_others"}},{"before":"cbc56c51c86f75e64acaede97edcab34d529b068","after":"d4c170c49f6cbe099db937c9b0a8dcda648873dc","ref":"refs/heads/1110","pushedAt":"2024-06-18T13:53:26.000Z","pushType":"pr_merge","commitsCount":4,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Merge pull request #1000 from deepakala-k/update_state_and_others\n\nUpdate state and others","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2350206992\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1000\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1000/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1000\">#1000</a> from deepakala-k/update_state_and_others"}},{"before":"a7c4f8cd3955fa548d748d6ca5542e6396b285fd","after":"cbc56c51c86f75e64acaede97edcab34d529b068","ref":"refs/heads/1110","pushedAt":"2024-06-14T15:56:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Fix Redfish Validator Errors on system (#1004)\n\nThere are a few Redfish Service Validator errors like\r\n\r\n```\r\npython3 RedfishServiceValidator.py --auth Session -i https://${bmc} -u $USER -p $PASS \\\r\n        --payload Single /redfish/v1/Systems/system\r\n...\r\n1 failInvalidArray errors in /redfish/v1/Systems/system\r\n1 fails errors in /redfish/v1/Systems/system\r\n```\r\n\r\nIts details are:\r\n\r\n```\r\nERROR - Property EnabledPanelFunctions should not be a List\r\nERROR - This object's type EnabledPanelFunctions should be a Collection, but it's of type Resource.OemObject...\r\nERROR - EnabledPanelFunctions: Value of property is an array but is not a Collection\r\n```\r\n\r\n```\r\n{\r\n    \"@odata.id\": \"/redfish/v1/Systems/system\",\r\n\r\n    \"Oem\": {\r\n        \"@odata.type\": \"#OemComputerSystem.Oem\",\r\n        \"IBM\": {\r\n            \"@odata.type\": \"#OemComputerSystem.IBM\", <---\r\n            \"EnabledPanelFunctions\": [],\r\n            \"LampTest\": false,\r\n            \"PartitionSystemAttentionIndicator\": false,\r\n            \"PlatformSystemAttentionIndicator\": false,\r\n            \"SafeMode\": false\r\n        }\r\n    },\r\n```\r\n\r\nTested:\r\n- Redfish Service Validator passes for `/redfish/v1/Systems/system`\r\n\r\nSigned-off-by: Myung Bae <myungbae@us.ibm.com>","shortMessageHtmlLink":"Fix Redfish Validator Errors on system (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2352089338\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/1004\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/1004/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/1004\">#1004</a>)"}},{"before":"ef3a784ed8ff48f99fd5368c527b2aadbcaa5213","after":"a7c4f8cd3955fa548d748d6ca5542e6396b285fd","ref":"refs/heads/1110","pushedAt":"2024-06-14T14:28:54.000Z","pushType":"pr_merge","commitsCount":4,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Merge pull request #994 from deepakala-k/GetAncestor\n\nGet ancestor","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2338812459\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/994\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/994/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/994\">#994</a> from deepakala-k/GetAncestor"}},{"before":"aace8d1e45fa7808a18a9455ec24941de3021dfd","after":"ef3a784ed8ff48f99fd5368c527b2aadbcaa5213","ref":"refs/heads/1110","pushedAt":"2024-06-13T13:59:16.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"RedfishEvents: Disable peer certificate verfication (#993)\n\nThis is downstream only commit to disable peer certificate verfication\r\nin redfish events path.\r\n\r\nCurrently HMC-BMC certificate flows are not supported, so this commit\r\ndisable peer certificate verfication during ssl handshake.\r\n\r\nTested by:\r\nVerified redfish events on HMC","shortMessageHtmlLink":"RedfishEvents: Disable peer certificate verfication (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2338764865\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/993\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/993/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/993\">#993</a>)"}},{"before":"d2d219626106c539732c667474f9fa0ff7a72a19","after":"aace8d1e45fa7808a18a9455ec24941de3021dfd","ref":"refs/heads/1110","pushedAt":"2024-06-12T15:01:15.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Fix Link FabricAdapter to PCIeDevice (#999)\n\nLink from FabricAdapter to PCIeDevice is incorrectly set\r\nwithout using the buildUniquePath.\r\n\r\n```\r\n{\r\n    \"@odata.id\": \"/redfish/v1/Systems/system/FabricAdapters/motherboard-pcieslot11-pcie_card11\",\r\n    \"@odata.type\": \"#FabricAdapter.v1_4_0.FabricAdapter\",\r\n    \"Id\": \"motherboard-pcieslot11-pcie_card11\",\r\n        \"PCIeDevices\": [\r\n            {\r\n                \"@odata.id\": \"/redfish/v1/Systems/system/PCIeDevices/pcie_card11\"\r\n            }\r\n        ],\r\n        PCIeDevices@odata.count: 1\r\n    },\r\n```\r\n\r\nThis also causes Redfish Service Validator failure.\r\n\r\nThis will be set like\r\n\r\n```\r\n    \"Links\": {\r\n        \"PCIeDevices\": [\r\n            {\r\n                \"@odata.id\": \"/redfish/v1/Systems/system/PCIeDevices/chassis_motherboard-pcieslot11-pcie_card11\"\r\n            }\r\n```\r\n\r\nTested:\r\n- Check the output of\r\n  `/redfish/v1/Systems/system/FabricAdapters/motherboard-pcieslot11-pcie_card11`\r\n\r\n- Redfish Service Validator passes\r\n\r\nSigned-off-by: Myung Bae <myungbae@us.ibm.com>","shortMessageHtmlLink":"Fix Link FabricAdapter to PCIeDevice (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2348780894\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/999\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/999/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/999\">#999</a>)"}},{"before":"c4aa7b17707155e7f0cbccfcb20471228b41b46d","after":"d2d219626106c539732c667474f9fa0ff7a72a19","ref":"refs/heads/1110","pushedAt":"2024-06-12T13:33:06.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Fix Assembly ReadyToRemove GET (#997)\n\nIt currently produces Assembly output with the incorrect ReadyToRemove\r\nfield where it should not be included.\r\n\r\n```\r\ncurl -k -X GET https://${bmc}/redfish/v1/Chassis/chassis/Assembly\r\n{\r\n...\r\n  \"Assemblies\": [\r\n    {\r\n      \"@odata.id\": \"/redfish/v1/Chassis/chassis/Assembly#/Assemblies/0\",\r\n      \"@odata.type\": \"#Assembly.v1_3_0.AssemblyData\",\r\n      ...\r\n      \"Name\": \"motherboard\",\r\n      \"Oem\": {\r\n        \"OpenBMC\": {\r\n          \"ReadyToRemove\": false     <== This should not be included\r\n        }\r\n      },\r\n      ...\r\n    },\r\n```\r\n\r\nThis will also cause the Redfish Service Validator error because\r\nit does not contain the @odata.type.\r\n\r\nTested:\r\n- Verify `curl -k -X GET https://${bmc}/redfish/v1/Chassis/chassis/Assembly`\r\n- Redfish Service Validator passes\r\n\r\n```\r\npython3 RedfishServiceValidator.py --auth Session -i https://${bmc} -u $USER -p $PASS \\\r\n        --payload Single /redfish/v1/Chassis/chassis/Assembly\r\n```\r\n\r\nSigned-off-by: Myung Bae <myungbae@us.ibm.com>","shortMessageHtmlLink":"Fix Assembly ReadyToRemove GET (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2347075390\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/997\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/997/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/997\">#997</a>)"}},{"before":"a0481e288ba79a8b5764eeba475c7478c859d24e","after":"c4aa7b17707155e7f0cbccfcb20471228b41b46d","ref":"refs/heads/1110","pushedAt":"2024-06-12T13:32:54.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Handle Missing PCIeSlot LinkStatus (#996)\n\nNot all PCIeSlots may have LinkStatus DBus properties.\r\nCurrently it fails on PCIeDevice GET object like\r\n\r\n```\r\ncurl -k -X GET https://${bmc}/redfish/v1/Systems/system/PCIeDevices/chassis_motherboard_pcieslot0_pcie_card0\r\n{\r\n...\r\n\r\n    \"code\": \"Base.1.16.0.InternalError\",\r\n    \"message\": \"The request failed due to an internal service error.  The service is still operational.\"\r\n  }\r\n```\r\n\r\nIts journal record may be:\r\n```\r\n[ERROR dbus_utils.hpp:20] DBUS property error in property: LinkStatus, reason: 0\r\n[CRITICAL error_messages.cpp:286] Internal Error /usr/src/debug/bmcweb/1.0+git/redfish-core/lib/pcie.hpp(259:32)\r\n     `void redfish::addPCIeSlotProperties(crow::Response&, const boost::system::error_code&, const dbus::utility::DBusPropertiesMap&)`:\r\n```\r\n\r\nThis is to handle the case when the dbus field is not presented, like\r\nhow it was handled in the previous release\r\n\r\nTested:\r\n\r\n-Check the success of GET on non-existent PCIeDevice LinkStatus\r\n```\r\ncurl -k -X GET https://${bmc}/redfish/v1/Systems/system/PCIeDevices/chassis_motherboard_pcieslot0_pcie_card0\r\n```\r\n\r\nSigned-off-by: Myung Bae <myungbae@us.ibm.com>","shortMessageHtmlLink":"Handle Missing PCIeSlot LinkStatus (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2346524112\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/996\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/996/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/996\">#996</a>)"}},{"before":"74a0b78d51b3d1f7c5d7ea90b13e13140efe596a","after":"a0481e288ba79a8b5764eeba475c7478c859d24e","ref":"refs/heads/1110","pushedAt":"2024-06-11T20:56:21.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Fix handling of lanesInUse default value (#851)\n\nphophor-dbus-interfaces changes the default of lanesInUse to MAXINT by\r\nhttps://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/53650\r\n\r\nThus bmcweb also changes the logic to show the field as null if it is\r\nMAXINT.\r\n\r\nChange-Id: Ib229112374eb5a65e0a8ac97669c09c498ac26c7\r\n\r\nSigned-off-by: Myung Bae <myungbae@us.ibm.com>","shortMessageHtmlLink":"Fix handling of lanesInUse default value (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2184021714\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/851\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/851/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/851\">#851</a>)"}},{"before":"a33fa9a4d1528126ba92b9290915811ef1132201","after":"9e4fb79dc356d1e4d17df166e1346e719605d804","ref":"refs/heads/1060","pushedAt":"2024-06-10T18:27:38.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Add missing path to SubProcessors from Processor (#995)\n\nSince SubProcessors are supported there should be a link from the\r\nProcessor to the Redfish URI for its SubProcessors. It is missing.\r\n\r\nWithout fix:\r\n```\r\ncurl -k -H \"X-Auth-Token: $token\" https://${bmc}/redfish/v1/Systems/system/Processors/dcm0-cpu0\r\n{\r\n  \"@odata.id\": \"/redfish/v1/Systems/system/Processors/dcm0-cpu0\",\r\n  \"@odata.type\": \"#Processor.v1_18_0.Processor\",\r\n  \"Id\": \"dcm0-cpu0\",\r\n  \"Location\": {\r\n    \"PartLocation\": {\r\n      \"ServiceLabel\": \"U78DA.ND0.1234567-P0-C15\"\r\n    }\r\n  },\r\n  \"LocationIndicatorActive\": false,\r\n  \"Manufacturer\": \"\",\r\n  \"MaxSpeedMHz\": 0,\r\n  \"Model\": \"AB42\",\r\n  \"Name\": \"System processor module 0\",\r\n  \"PartNumber\": \"2345678\",\r\n  \"ProcessorId\": {\r\n    \"Step\": \"0xFFFF\"\r\n  },\r\n  \"ProcessorType\": \"CPU\",\r\n  \"SerialNumber\": \"YLAB42010000\",\r\n  \"Socket\": \"\",\r\n  \"SparePartNumber\": \"1234567\",\r\n  \"Status\": {\r\n    \"Health\": \"OK\",\r\n    \"State\": \"Enabled\"\r\n  },\r\n  \"ThrottleCauses\": [],\r\n  \"Throttled\": false,\r\n  \"TotalCores\": 0,\r\n  \"TotalThreads\": 0\r\n}\r\n\r\ncurl -k -H \"X-Auth-Token: $token\" https://${bmc}/redfish/v1/Systems/system/Processors/dcm0-cpu0/SubProcessors\r\n{\r\n  \"@odata.id\": \"/redfish/v1/Systems/system/Processors/dcm0-cpu0/SubProcessors\",\r\n  \"@odata.type\": \"#ProcessorCollection.ProcessorCollection\",\r\n  \"Members\": [],\r\n  \"Members@odata.count\": 0,\r\n  \"Name\": \"SubProcessor Collection\"\r\n}\r\n```\r\n\r\nTested:\r\n  - Redfish Validator passes\r\n  - Path is returned\r\n\r\nWith fix, now see SubProcessor path:\r\n```\r\ncurl -k -H \"X-Auth-Token: $token\" https://${bmc}/redfish/v1/Systems/system/Processors/dcm0-cpu0/\r\n{\r\n  \"@odata.id\": \"/redfish/v1/Systems/system/Processors/dcm0-cpu0\",\r\n  \"@odata.type\": \"#Processor.v1_18_0.Processor\",\r\n  \"Id\": \"dcm0-cpu0\",\r\n  \"Location\": {\r\n    \"PartLocation\": {\r\n      \"ServiceLabel\": \"U78DA.ND0.1234567-P0-C15\"\r\n    }\r\n  },\r\n  \"LocationIndicatorActive\": false,\r\n  \"Manufacturer\": \"\",\r\n  \"MaxSpeedMHz\": 0,\r\n  \"Model\": \"AB42\",\r\n  \"Name\": \"System processor module 0\",\r\n  \"PartNumber\": \"2345678\",\r\n  \"ProcessorId\": {\r\n    \"Step\": \"0xFFFF\"\r\n  },\r\n  \"ProcessorType\": \"CPU\",\r\n  \"SerialNumber\": \"YLAB42010000\",\r\n  \"Socket\": \"\",\r\n  \"SparePartNumber\": \"1234567\",\r\n  \"Status\": {\r\n    \"Health\": \"OK\",\r\n    \"State\": \"Enabled\"\r\n  },\r\n  \"SubProcessors\": {\r\n    \"@odata.id\": \"/redfish/v1/Systems/system/Processors/dcm0-cpu0/SubProcessors\"\r\n  },\r\n  \"ThrottleCauses\": [],\r\n  \"Throttled\": false,\r\n  \"TotalCores\": 0,\r\n  \"TotalThreads\": 0\r\n}\r\n```\r\n\r\nSigned-off-by: Janet Adkins <janeta@us.ibm.com>","shortMessageHtmlLink":"Add missing path to SubProcessors from Processor (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2339073089\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/995\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/995/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/995\">#995</a>)"}},{"before":"ef8f47021650ff8841a5f6249acce6b6a82cc1cc","after":"74a0b78d51b3d1f7c5d7ea90b13e13140efe596a","ref":"refs/heads/1110","pushedAt":"2024-06-07T13:26:37.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rfrandse","name":"Reed Frandsen","path":"/rfrandse","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15894767?s=80&v=4"},"commit":{"message":"Logging invalid service name for debug (#291) (#626) (#992)\n\nThe method getPrettyName() may be called more than one time.\r\nThis will generate journal logging messages for the required Service name\r\nif there are unexpected service names.\r\n\r\nSigned-off-by: Abhishek Patel <Abhishek.Patel@ibm.com>\r\nSigned-off-by: Myung Bae <myungbae@us.ibm.com>\r\nCo-authored-by: patelabhishek9893 <82394680+patelabhishek9893@users.noreply.github.com>\r\nCo-authored-by: Abhishek Patel <Abhishek.Patel@ibm.com>","shortMessageHtmlLink":"Logging invalid service name for debug (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1173134915\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/291\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/291/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/291\">#291</a>) (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1627489407\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/626\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/626/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/626\">#626</a>) (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2338398057\" data-permission-text=\"Title is private\" data-url=\"https://github.com/ibm-openbmc/bmcweb/issues/992\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/ibm-openbmc/bmcweb/pull/992/hovercard\" href=\"https://github.com/ibm-openbmc/bmcweb/pull/992\">#992</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEgOtZoAA","startCursor":null,"endCursor":null}},"title":"Activity · ibm-openbmc/bmcweb"}