configuration: system1: Add GPIO monitoring type #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some GPIOs do not support event_read method to monitor for value changes. Added a new MonitorType field to specify if the GPIO needs to be manually polled to detect presence. Also added PCIE Switch temperature sensors Tested: - Verified no change when MonitorType not specified - Verified functionality when Polling enum was specified Change-Id: Ie5e8a2afe43d05192828292b629baade6b0c9c82 Signed-off-by: Chris Cain <cjcain@us.ibm.com>
Contributor
|
add to approvelist |
Contributor
|
jenkins run tests please |
spinler
approved these changes
Oct 1, 2024
Contributor
spinler
left a comment
spinler
left a comment
There was a problem hiding this comment.
There's a few other changes in here too?
Contributor
Author
|
Yes, also had to update a few of the fan parameters. |
rfrandse
pushed a commit
that referenced
this pull request
Oct 2, 2024
Some GPIOs do not support event_read method to monitor for value changes. Added a new MonitorType field to specify if the GPIO needs to be manually polled to detect presence. Also added PCIE Switch temperature sensors Tested: - Verified no change when MonitorType not specified - Verified functionality when Polling enum was specified Change-Id: Ie5e8a2afe43d05192828292b629baade6b0c9c82 Signed-off-by: Chris Cain <cjcain@us.ibm.com>
geissonator
pushed a commit
to geissonator/entity-manager
that referenced
this pull request
Nov 6, 2024
Some GPIOs do not support event_read method to monitor for value changes. Added a new MonitorType field to specify if the GPIO needs to be manually polled to detect presence. Also added PCIE Switch temperature sensors Tested: - Verified no change when MonitorType not specified - Verified functionality when Polling enum was specified Change-Id: Ie5e8a2afe43d05192828292b629baade6b0c9c82 Signed-off-by: Chris Cain <cjcain@us.ibm.com>
geissonator
pushed a commit
to geissonator/entity-manager
that referenced
this pull request
Nov 6, 2024
Some GPIOs do not support event_read method to monitor for value changes. Added a new MonitorType field to specify if the GPIO needs to be manually polled to detect presence. Also added PCIE Switch temperature sensors Tested: - Verified no change when MonitorType not specified - Verified functionality when Polling enum was specified Change-Id: Ie5e8a2afe43d05192828292b629baade6b0c9c82 Signed-off-by: Chris Cain <cjcain@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some GPIOs do not support event_read method to monitor for value changes. Added a new MonitorType field to specify if the GPIO needs to be manually polled to detect presence.
Also added PCIE Switch temperature sensors
Tested:
Change-Id: Ie5e8a2afe43d05192828292b629baade6b0c9c82