configuration: system1: Fix fan indexing problem #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dual rotor fans are indexed by 1 rotor for each fan, followed by the
second rotor for those fans.
Tested on system1 hw
Before:
Fan Rotor Present RPM PWM: % Target Zone
--- -------- ------- ----- ------ ------ ----
Fan1 Fan1a_in true 4102 39.22 100% 0 (CECIO)
Fan1 Fan1b_in true 4054
Fan2 Fan2a_in true 4032 39.22 100% 0 (CECIO)
Fan2 Fan2b_in true 4089
Fan3 Fan3a_in true 4040 39.22 100% 0 (CECIO)
Fan3 Fan3b_in true 0
Fan4 Fan4a_in true 0 39.22 100% 0 (CECIO)
Fan4 Fan4b_in true 0
Fan5 Fan5a_in true 0 39.22 100% 0 (CECIO)
Fan5 Fan5b_in true 0
Fan6 Fan6_in false 0 39.22 100% 1 (NVME)
Fan7 Fan7_in false 0 39.22 100% 1 (NVME)
After: Fan Rotor Present RPM PWM: % Target Zone
--- -------- ------- ----- ------ ------ ----
Fan1 Fan1a_in true 3972 39.22 100% 0 (CECIO)
Fan1 Fan1b_in true 0
Fan2 Fan2a_in true 4002 39.22 100% 0 (CECIO)
Fan2 Fan2b_in true 0
Fan3 Fan3a_in true 4054 39.22 100% 0 (CECIO)
Fan3 Fan3b_in true 0
Fan4 Fan4a_in true 4027 39.22 100% 0 (CECIO)
Fan4 Fan4b_in true 0
Fan5 Fan5a_in true 4054 39.22 100% 0 (CECIO)
Fan5 Fan5b_in true 0
Fan6 Fan6_in false 0 39.22 100% 1 (NVME)
Fan7 Fan7_in false 0 39.22 100% 1 (NVME)
Change-Id: Iee747f9b22099719f5d90296c5154b047b74880c
spinler
approved these changes
Nov 6, 2024
geissonator
pushed a commit
to geissonator/entity-manager
that referenced
this pull request
Nov 6, 2024
The dual rotor fans are indexed by 1 rotor for each fan, followed by the
second rotor for those fans.
Tested on system1 hw
Before:
Fan Rotor Present RPM PWM: % Target Zone
--- -------- ------- ----- ------ ------ ----
Fan1 Fan1a_in true 4102 39.22 100% 0 (CECIO)
Fan1 Fan1b_in true 4054
Fan2 Fan2a_in true 4032 39.22 100% 0 (CECIO)
Fan2 Fan2b_in true 4089
Fan3 Fan3a_in true 4040 39.22 100% 0 (CECIO)
Fan3 Fan3b_in true 0
Fan4 Fan4a_in true 0 39.22 100% 0 (CECIO)
Fan4 Fan4b_in true 0
Fan5 Fan5a_in true 0 39.22 100% 0 (CECIO)
Fan5 Fan5b_in true 0
Fan6 Fan6_in false 0 39.22 100% 1 (NVME)
Fan7 Fan7_in false 0 39.22 100% 1 (NVME)
After: Fan Rotor Present RPM PWM: % Target Zone
--- -------- ------- ----- ------ ------ ----
Fan1 Fan1a_in true 3972 39.22 100% 0 (CECIO)
Fan1 Fan1b_in true 0
Fan2 Fan2a_in true 4002 39.22 100% 0 (CECIO)
Fan2 Fan2b_in true 0
Fan3 Fan3a_in true 4054 39.22 100% 0 (CECIO)
Fan3 Fan3b_in true 0
Fan4 Fan4a_in true 4027 39.22 100% 0 (CECIO)
Fan4 Fan4b_in true 0
Fan5 Fan5a_in true 4054 39.22 100% 0 (CECIO)
Fan5 Fan5b_in true 0
Fan6 Fan6_in false 0 39.22 100% 1 (NVME)
Fan7 Fan7_in false 0 39.22 100% 1 (NVME)
Change-Id: Iee747f9b22099719f5d90296c5154b047b74880c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dual rotor fans are indexed by 1 rotor for each fan, followed by the second rotor for those fans.
Tested on system1 hw
Before:
Fan Rotor Present RPM PWM: % Target Zone
--- -------- ------- ----- ------ ------ ----
Fan1 Fan1a_in true 4102 39.22 100% 0 (CECIO)
Fan1 Fan1b_in true 4054
Fan2 Fan2a_in true 4032 39.22 100% 0 (CECIO)
Fan2 Fan2b_in true 4089
Fan3 Fan3a_in true 4040 39.22 100% 0 (CECIO)
Fan3 Fan3b_in true 0
Fan4 Fan4a_in true 0 39.22 100% 0 (CECIO)
Fan4 Fan4b_in true 0
Fan5 Fan5a_in true 0 39.22 100% 0 (CECIO)
Fan5 Fan5b_in true 0
Fan6 Fan6_in false 0 39.22 100% 1 (NVME)
Fan7 Fan7_in false 0 39.22 100% 1 (NVME)
After: Fan Rotor Present RPM PWM: % Target Zone
--- -------- ------- ----- ------ ------ ----
Fan1 Fan1a_in true 3972 39.22 100% 0 (CECIO)
Fan1 Fan1b_in true 0
Fan2 Fan2a_in true 4002 39.22 100% 0 (CECIO)
Fan2 Fan2b_in true 0
Fan3 Fan3a_in true 4054 39.22 100% 0 (CECIO)
Fan3 Fan3b_in true 0
Fan4 Fan4a_in true 4027 39.22 100% 0 (CECIO)
Fan4 Fan4b_in true 0
Fan5 Fan5a_in true 4054 39.22 100% 0 (CECIO)
Fan5 Fan5b_in true 0
Fan6 Fan6_in false 0 39.22 100% 1 (NVME)
Fan7 Fan7_in false 0 39.22 100% 1 (NVME)
Change-Id: Iee747f9b22099719f5d90296c5154b047b74880c