zipl: fix reading 4k disk's geometry #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1918723 On 4k SCSI disks zipl stores wrong values to 'scsi_mbr.program_table_pointer', which makes system unbootable. This happens in 'zipl/src/disk.c:656': ``` /* Convert file system block to physical */ *physical = mapped * phy_per_fs + subblock; /* Add partition start */ *physical += info->geo.start; ``` So 'hd_geometry.start' should be adjusted before being used. Signed-off-by: Nikita Dubrovskii <nikita@linux.ibm.com>
nikita-dubrovskii
force-pushed
the
4k_fix
branch
from
0d50344
to
0b1f11d
Compare
stefan-haberland
approved these changes
Feb 12, 2021
|
Thanks for the patch. With the rework I am fine with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1918723
On 4k SCSI disks zipl stores wrong values to 'scsi_mbr.program_table_pointer',
which makes system unbootable.
This happens in 'zipl/src/disk.c:656':
So 'hd_geometry.start' should be adjusted before being used.
Signed-off-by: Nikita Dubrovskii nikita@linux.ibm.com