Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while pulling images (Wrong tag name) #5

Closed
4 tasks done
erNail opened this issue Oct 17, 2018 · 2 comments
Closed
4 tasks done

Error while pulling images (Wrong tag name) #5

erNail opened this issue Oct 17, 2018 · 2 comments

Comments

@erNail
Copy link
Contributor

erNail commented Oct 17, 2018

Right now, the tag name consists of $ARCH-$VERSION. Since Fabric 1.2 (i think), those tag name is not used anymore for the "x86_64" architecture. For example, the current one for this architecture is "1.3.0".

There are 3 problems with the tag handling at the moment:

  • Tag naming conventions can change (No $ARCH variable anymore)
  • Thirdparty images (couchdb, zookeeper, kafka) have a different version and tag than the fabric images
  • CA image can have a different version and tag than the fabric images (At least it's seperated in the fabric binaries setup script)

I propose the following:

  • In the samplenet.yaml, remove VERSION and ARCH
  • In the samplenet.yaml, add FABRIC_VERSION_TAG, CA_VERSION_TAG, THIRDPARTY_VERSION_TAG (Similiar to the fabric binaries setup script). This prevents a dependency on the tag naming convention.
  • In the pull-docker-images-template.sh, differentiate between fabric images, ca image and thirdparty images
  • In the docker-compose-template.yaml, differentiate between fabric images, ca image and thirdparty images

I'm currently implementing these changes. I'll create a Pull Request as soon as i'm done.

@erNail
Copy link
Contributor Author

erNail commented Oct 23, 2018

Fixed, waiting for Pull Request #7 to be accepted.

@jeroiraz
Copy link
Contributor

jeroiraz commented Nov 6, 2018

Thanks @erNail

@jeroiraz jeroiraz closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants