From 09b00d7512e25c680204e47e61309f6a690babfc Mon Sep 17 00:00:00 2001 From: Vivek Shankar Date: Fri, 14 Nov 2025 14:19:34 +0800 Subject: [PATCH 1/4] fix: use newer versions --- .github/workflows/publishpackage.yml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/publishpackage.yml b/.github/workflows/publishpackage.yml index e71b9d9..0a70f57 100644 --- a/.github/workflows/publishpackage.yml +++ b/.github/workflows/publishpackage.yml @@ -3,6 +3,10 @@ name: Publish packages to NPM on: release: types: [created] + push: + branches: + - develop + - main permissions: id-token: write @@ -16,14 +20,15 @@ jobs: contents: read packages: write steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 # Setup .npmrc file to publish - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v4 with: - node-version: '16.x' + node-version: 20 registry-url: 'https://registry.npmjs.org' - name: Publish package to NPM env: + EVENT_TYPE: ${{ github.event_name }} IS_PRERELEASE: ${{ github.event.release.prerelease }} run: | echo "Update npm" From d8fe268d1bf57417485ea1d07fcf683b7c9421eb Mon Sep 17 00:00:00 2001 From: Vivek Shankar Date: Fri, 14 Nov 2025 14:22:51 +0800 Subject: [PATCH 2/4] fix: introduce branch push option --- .github/workflows/publishpackage.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publishpackage.yml b/.github/workflows/publishpackage.yml index 0a70f57..e80da25 100644 --- a/.github/workflows/publishpackage.yml +++ b/.github/workflows/publishpackage.yml @@ -44,7 +44,7 @@ jobs: npm ci npm run build --if-present - if [ "$IS_PRERELEASE" = "true" ]; then + if [[ "$EVENT_TYPE" == "push" || ["$IS_PRERELEASE" == "true" ]]; then echo "It's a pre-release." npm publish --dry-run --access public else From 9724b6f098165731a9379ad24369c51cb9dc11d5 Mon Sep 17 00:00:00 2001 From: Vivek Shankar Date: Fri, 14 Nov 2025 14:28:14 +0800 Subject: [PATCH 3/4] ci: tags are needed --- .github/workflows/publishpackage.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/publishpackage.yml b/.github/workflows/publishpackage.yml index e80da25..2094dae 100644 --- a/.github/workflows/publishpackage.yml +++ b/.github/workflows/publishpackage.yml @@ -4,9 +4,8 @@ on: release: types: [created] push: - branches: - - develop - - main + tags: + - '**' permissions: id-token: write From 6407a581a1f21ab1303b9d7489cf3149b2bb6857 Mon Sep 17 00:00:00 2001 From: Vivek Shankar Date: Fri, 14 Nov 2025 14:46:17 +0800 Subject: [PATCH 4/4] fix: comment out the ci and build steps --- .github/workflows/publishpackage.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/publishpackage.yml b/.github/workflows/publishpackage.yml index 2094dae..66c6672 100644 --- a/.github/workflows/publishpackage.yml +++ b/.github/workflows/publishpackage.yml @@ -39,9 +39,9 @@ jobs: # This step would fail if module is not a valid sdk cd ${GITHUB_WORKSPACE}/sdk/${MODULE} - echo "Building package" - npm ci - npm run build --if-present + # echo "Building package" + # npm ci + # npm run build --if-present if [[ "$EVENT_TYPE" == "push" || ["$IS_PRERELEASE" == "true" ]]; then echo "It's a pre-release."