Skip to content
Commits on Mar 8, 2016
  1. @fujiwarat

    Don't warn if DISPLAY is not set

    This is normal under Wayland, and not worth warning about.
    The warnings disrupt unit tests in GNOME continuous, which
    treat warnings as fatal.
    
    BUG=#1844
    R=shawn.p.huang@gmail.com
    
    Review URL: https://codereview.appspot.com/289430043
    
    Patch from Matthias Clasen <mclasen@redhat.com>.
    Matthias Clasen committed with fujiwarat Mar 8, 2016
Commits on Feb 22, 2016
  1. @fujiwarat

    Release 1.5.13

    fujiwarat committed Feb 22, 2016
Commits on Feb 17, 2016
  1. @ueno

    Add SetCursorLocationRelative D-Bus method

    We have SetCursorLocation D-Bus method which takes the absolute
    coordinates of the screen, while on Wayland the coordinates are relative
    to the current input window and there is no way to calculate the
    absolute coordinates.  That makes it impossible for the panel to
    position the lookup table correctly.
    
    This patch adds a new D-Bus method, SetCursorLocationRelative, which
    takes the relative coordinates, so that the panel
    implementation (typically the same process of Wayland compositor) can
    use that information.  The counterpart of this changes is at:
    https://bugzilla.gnome.org/show_bug.cgi?id=753476
    
    Unlike SetCursorLocation, SetCursorLocationRelative is not delivered to
    engines, since it is not very useful for the engines without knowing the
    current input window (which is also not accessible from a different
    process on Wayland).
    
    Co-authored-by: Rui Matos <tiagomatos@gmail.com>
    
    BUG=
    R=takao.fujiwara1@gmail.com
    
    Review URL: https://codereview.appspot.com/290780043 .
    ueno committed Feb 17, 2016
Commits on Feb 10, 2016
  1. @fujiwarat

    src: Use cache file for compose table for launching time

    Save the cache files of compose files under $HOME/.cache/ibus/compose
    for the performance.
    
    Load a compose file with the following order:
    1. $HOME/.config/ibus/Compose
    2. $HOME/.config/gtk-3.0/Compose
    3. $HOME/.XCompose
    4. /usr/share/X11/locale/$locale/Compose
    
    Check the system compose files of "el_GR", "fi_FI", "pt_BR" only for the
    performance because other compose files just load "en_US" compose file.
    
    BUG=https://bugzilla.gnome.org/show_bug.cgi?id=721120
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/286040043
    fujiwarat committed Feb 10, 2016
Commits on Feb 1, 2016
  1. @fujiwarat

    src: Refactor ibuscomposetable.c

    Save raw integers of Unicode instead of code strings.
    Use g_warning() instead of g_set_error().
    
    BUG=https://bugzilla.gnome.org/show_bug.cgi?id=721120
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/282390044
    fujiwarat committed Feb 1, 2016
Commits on Jan 29, 2016
  1. @fujiwarat

    src: Change guint to guint16 in ibusenginesimple.c

    IBusComposeTable and IBusComposeTableCompact use guint16 for the data.
    
    BUG=https://bugzilla.gnome.org/show_bug.cgi?id=721120
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/282390043
    fujiwarat committed Jan 29, 2016
  2. @fujiwarat

    src: Unify duplicated check_compact_table() and check_algorithmically()

    Clean up the duplicated APIs, check_compact_table() and
    check_algorithmically(), in ibuscomposetable.c and ibusenginesimple.c
    
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/286930043
    fujiwarat committed Jan 29, 2016
Commits on Jan 20, 2016
  1. @fujiwarat

    Release 1.5.12 (#2)

    Fix a build failure with make check.
    
    Review URL: https://codereview.appspot.com/285910043
    fujiwarat committed Jan 20, 2016
Commits on Jan 19, 2016
  1. @fujiwarat

    Release 1.5.12

    fujiwarat committed Jan 19, 2016
  2. @fujiwarat

    Update translations

    Update bn.po ca.po zh_CN.po zh_HK.po
    
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/272450043
    fujiwarat committed Jan 19, 2016
Commits on Jan 15, 2016
  1. @fujiwarat
Commits on Jan 14, 2016
  1. @fujiwarat
Commits on Nov 4, 2015
  1. @fujiwarat

    panel: Fix the default position of property panel with dual monitors

    "_NET_WORKAREA" Atom returns a big screen size including every monitors.
    Use Gdk.Screen.get_monitor_workarea() instead.
    
    Review URL: https://codereview.appspot.com/277760043
    fujiwarat committed Nov 4, 2015
  2. @koterpillar @fujiwarat

    panel: Constrain the candidate area to the current monitor bounds

    If the second monitor has the different size, lookup window on
    the second monitor could not get the right size.
    
    BUG=#1594
    
    Review URL: https://codereview.appspot.com/267710043
    
    Patch from Alexey Kotlyarov <a@koterpillar.com>.
    koterpillar committed with fujiwarat Nov 4, 2015
Commits on Sep 8, 2015
  1. @fujiwarat

    ibus-daemon update user cache when user observed path is updated

    After the system registry cache is generated by root,
    the cache remembers the observed path exists in /root == '~'
    but if a user updates the user observed path, the observed path
    exists in '~' and ibus-daemon cannot get the updated mtime
    because the cache refers the root directory but not the user directory.
    The patch tries to save '~' instead of the actual home dir
    in the cache.
    
    BUG=#1815
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/261040043
    fujiwarat committed Sep 8, 2015
Commits on Sep 1, 2015
  1. @Keruspe @fujiwarat

    check for x11 for the ui too

    if built with --enable-ui --disable-xim it currently fails because
    X11_LIBS is empty
    
    BUG=#1812
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/264020043
    
    Patch from Marc-Antoine Perennou <Marc-Antoine@Perennou.com>.
    Keruspe committed with fujiwarat Sep 1, 2015
Commits on Aug 14, 2015
  1. @fujiwarat

    Add terminator in NO_SNOOPER_APPS

    terminator connects "key-press-event" signal in VTE and receives the
    KeyPress events and copies the events to the multiple terminals.
    If IBus uses snooper and IBusIMContext returns true,
    terminator cannot receive the IME events because VTE does not export
    IME "commit" signal.
    After move terminator in NO_SNOOPER_APPS, terminator can receive the
    KeyPress events from "key-press-event" signal before IBusIMContext
    key_press_event() class method receives the events.
    
    BUG=#1802
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/260120043
    fujiwarat committed Aug 14, 2015
Commits on Jul 21, 2015
  1. @cogniti @fujiwarat

    client/x11: Remove an unused variable

    BUG=#1808
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/256010044
    
    Patch from Hodong Kim <hodong@cogno.org>.
    cogniti committed with fujiwarat Jul 21, 2015
Commits on Jul 16, 2015
  1. @fujiwarat

    Release 1.5.11

    fujiwarat committed Jul 16, 2015
  2. @fujiwarat

    Update translations

    Update po/ar.po po/as.po po/bg.po po/bn.po po/bn_IN.po po/ca.po po/da.po
           po/de.po po/en_GB.po po/es.po po/et.po po/eu.po po/fa.po po/fr.po
           po/gu.po po/he.po po/hi.po po/hu.po po/ia.po po/it.po po/ja.po
           po/kn.po po/ko.po po/lv.po po/ml.po po/mr.po po/nb.po po/nl.po
           po/or.po po/pa.po po/pl.po po/pt_BR.po po/ru.po po/sr.po
           po/sr@latin.po po/ta.po po/te.po po/tg.po po/uk.po po/ur.po
           po/vi.po po/zh_CN.po po/zh_HK.po po/zh_TW.po
    
    Review URL: https://codereview.appspot.com/241700043
    fujiwarat committed Jul 16, 2015
  3. @fujiwarat

    Fix GIR warnings about XMLNode with g-ir-scanner

    Fix:
    ibusxml.h:62: Warning: IBus: ibus_xml_parse_file: return value:
    Unresolved type: 'XMLNode*'
    
    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/255210043
    fujiwarat committed Jul 16, 2015
Commits on Jul 13, 2015
  1. @fujiwarat

    Fix doc builds

    Generate:
    html/IBusEngineSimple.html
    
    Fix:
    ibuscomponent.h:137: Warning: IBus: "@Varargs" parameter is deprecated,
    please use "@..." instead:
     * @Varargs: the NULL-terminated arguments of the properties and values.
    
    ibuscomponent.h:83: Warning: IBus: GTK-Doc tag "Description:" has been
    deprecated:
     * description: Detailed description of component.
    
    ../../../src/ibusenumtypes.h:13: warning: Section ibusenumtypes is not
    defined in the ibus-sections.txt file.
    
    ../../../src/ibusenginesimple.h:39: warning: Section ibussimpleengine is
    not defined in the ibus-sections.txt file.
    
    ../../../src/ibusinternal.h:35: warning: Section ibusinternal is not
    defined in the ibus-sections.txt file.
    
    ../../../src/ibusattribute.h:138: warning: Parameter description for
    ibus_attribute_new::returns is not used from source code comment block.
    
    ../../../src/ibusattribute.h:161: warning: Parameter description for
    ibus_attribute_get_value::attr is missing in source code comment block.
    
    ../../../src/ibuscomponent.h:145: warning: Parameter description for
    ibus_component_new_varargs::... is missing in source code comment block.
    
    ../../../src/ibusconfig.h:95: warning: Parameter description for
    ibus_config_new::cancellable is missing in source code comment block.
    
    html/IBusBus.html:3540: warning: no link for:
    'ibus-bus-get-property-async' ->
    (<code class="function">ibus_bus_get_property_async()</code>).
    
    html/api-index-full.html:2989: warning: no link for:
    'ibus-ibuscomposetable' -> (ibuscomposetable).
    
    html/IBusAttribute.html:500: warning: no link for: 'FIXME:CAPS'
    -> (<code class="literal">FIXME</code>).
    
    html/ibus-ibuskeys.html:286: warning: no link for: 'IBUS-KEY-Enter'
    -> (<span class="type">IBUS_KEY_Enter</span>).
    
    html/IBusPanelService.html:574: warning: no link for:
    'cursor-down-lookup-table' ->
    (<code class="function">cursor_down_lookup_table()</code>).
    
    html/IBusEngine.html:1190: warning: no link for: 'cancel-hand-writing'
    -> (<code class="function">cancel_hand_writing()</code>).
    
    Review URL: https://codereview.appspot.com/247680043
    fujiwarat committed Jul 13, 2015
Commits on Jul 3, 2015
  1. @fujiwarat
Commits on Jun 29, 2015
  1. @fujiwarat

    Replace code.google.com with github.com

    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/252740043
    fujiwarat committed Jun 29, 2015
Commits on Jun 22, 2015
  1. @fujiwarat

    Add maintainers

    R=Shawn.P.Huang@gmail.com
    
    Review URL: https://codereview.appspot.com/249800043
    fujiwarat committed Jun 22, 2015
Commits on Jun 19, 2015
  1. @fujiwarat

    Enable to show a property on ibus panel icon

    If an engine sets the value of icon-prop-key of IBusEngineDesc to
    a property name of IBusProperty.key, the panel will show the engine
    property in the icon with a delayed time.
    This way can show both the engine icon and the engine mode in one icon.
    
    Review URL: https://codereview.appspot.com/248950043
    fujiwarat committed Jun 19, 2015
Commits on Jun 15, 2015
  1. @fujiwarat

    Support vertical writing with IBUS_INPUT_HINT_VERTICAL_WRITING

    GTK_INPUT_HINT_VERTICAL_WRITING has been supported in gtk 3.18
    Put the vertical lookup table at the left top of the cursor position
    in case of the vertical mode.
    Also the gtk client tries to get the character width not to overlap
    the character when the client window is moved to the screen left.
    
    BUG=https://code.google.com/p/ibus/issues/detail?id=1780
    
    Review URL: https://codereview.appspot.com/242140043
    fujiwarat committed Jun 15, 2015
Commits on Jun 12, 2015
  1. @fujiwarat

    Do not put lookup window at the minus position

    tweetdeck.twitter.com seems has hidden GdkWindow and does not provide
    the positive cursor position.
    
    BUG=#1801
    
    Review URL: https://codereview.appspot.com/246010043
    fujiwarat committed Jun 12, 2015
Commits on Jun 5, 2015
  1. @fujiwarat
Commits on Jun 3, 2015
  1. @fujiwarat
Commits on May 25, 2015
  1. @fujiwarat

    ibus-ui-gtk3: radio and check menu items work with GTK 3.16

    GTK 3.16 has cleared the radio buttons' state in
    gtk_radio_menu_item_set_group():
    https://git.gnome.org/browse/gtk+/commit/?id=955aed9227
    
    BUG=https://code.google.com/p/ibus/issues/detail?id=1784
    TEST=ui/gtk3/ibus-ui-gtk3
    
    Review URL: https://codereview.appspot.com/240100043
    fujiwarat committed May 25, 2015
Commits on May 22, 2015
  1. @fujiwarat

    Set sync process_key_event in ibus-x11

    If X11 client application spend time during XNextEvent(), e.g. sleep(1),
    under async process_key_event(), X11 does not keep the event order.
    I don't know why the event order is broken but now set the sync mode.
    
    BUG=https://code.google.com/p/ibus/issues/detail?id=1697
    TEST=client/x11/ibus-x11
    
    Review URL: https://codereview.appspot.com/240860043
    fujiwarat committed May 22, 2015
Commits on May 21, 2015
  1. @fujiwarat

    Enable null return in gobject-introspection

    TEST=src/IBus.gir bindings/vala/ibus.vapi
    
    Review URL: https://codereview.appspot.com/236410043
    fujiwarat committed May 21, 2015
  2. @fujiwarat

    Fix SEGV of ibus-x11 on wayland

    In case that ibus-x11 is built with gtk3, GdkDisplay can be
    GdkWaylandDisplay but not GdkX11Display so GDK_DISPLAY_XDISPLAY()
    and GDK_WINDOW_XID() does not work in wayland.
    
    TEST=client/x11/ibus-x11
    
    Review URL: https://codereview.appspot.com/234590043
    fujiwarat committed May 21, 2015
  3. @fujiwarat
Something went wrong with that request. Please try again.