New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make content plugins "portable". #4

Merged
merged 3 commits into from Aug 23, 2016

Conversation

Projects
None yet
3 participants
@mrmachine
Member

mrmachine commented Aug 23, 2016

By "portable", I mean we can simply copy an entire plugin package out of ICEkit to a new location, e.g. inside a project, install it from the new location, and have it work just as before, effectively forking the plugin package.

From that point on, we can make changes to the forked plugin package, e.g. to implement custom functionality that is only relevant to the one project.

sam-mi and others added some commits Aug 22, 2016

Merge branch 'develop' into feature/portable-icekit
Conflicts:
	docs/portable-apps.md
	icekit/blog_tools/abstract_models.py
	icekit/blog_tools/tests.py
Merge branch 'develop' into feature/portable-icekit
# Conflicts:
#	docs/changelog.md
#	icekit/blog_tools/tests.py
@coveralls

This comment has been minimized.

coveralls commented Aug 23, 2016

Coverage Status

Coverage remained the same at 0.0% when pulling 6c4dfee on feature/portable-icekit into 6581772 on develop.

mrmachine added a commit that referenced this pull request Aug 23, 2016

Make `icekit.plugins.image` more portable. See #4
* Add an `AppConfig` class.

* Explicitly define `AppConfig.label`, so it won't change when moved.

* Derive `AppConfig.name` from the module name, so we don't have to update it
  when moved.

* Use `apps.get_app()` or `apps.get_model()` to import models into other apps,
  to avoid importing models from `icekit.plugins.image` when moved.

@mrmachine mrmachine merged commit 6c4dfee into develop Aug 23, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 0.0%
Details

@mrmachine mrmachine deleted the feature/portable-icekit branch Aug 25, 2016

cogat pushed a commit that referenced this pull request Jun 7, 2017

Add tests showing issues with timezone handling for all-day events, re
…#4

Add unit tests that demonstrate we cannot sort occurrences with all-day
ones first as we wish, and that the overlapping filter does not return
all-day events when they are created with start/end datestimes in
timezones other than the system timezone.

cogat pushed a commit that referenced this pull request Jun 7, 2017

Add start/end dates to Occurrences and test timezone handling, re #4
NOTE: Only the `Timezones` tests pass after this change, further work
is pending to update the rest of the system to account for the
date/datetime changes to `Occurrences`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment