Turn on/off blur background #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreamazz
reviewed
Jun 17, 2019
| /// Custom container for the spinner | ||
| public class func useContainerView(_ sv: UIView?) { | ||
| customSuperview = sv | ||
| } | ||
|
|
||
|
|
||
| public static var showBlurBackground: Bool = true |
There was a problem hiding this comment.
Can you please add the inline documentation comments?
|
Hey @maxxfrazer |
|
Great, thanks! |
|
👍 Good point; just added and also mentioned the change near the bottom of the README
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
showBlurBackgroundBool for hiding the blur backgroundI love your spinner, but wanted something to be over the camera feed showing that something is processing, but allowing the user to still scan the area they're in.
My code changes are on L:143 and L:175
Xcode has automatically trimmed trailing whitespaces; if you don't like this I can add them back!
Let me know what you think, as there could be a good reason that you don't want users to be able to hide the background.
Cheers,
Max