Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow transforming sign-posted value #1

Merged
merged 1 commit into from Mar 4, 2020

Conversation

@freak4pc
Copy link
Contributor

freak4pc commented Feb 28, 2020

Saw @cliss' idea and thought it would be a neat little contribution.
Let me know what you think :)

Given some Output == [String], you can do:

lane("thing") { "Got \($0.count) results" }

If you prefer a different syntax / structure, happy to make changes.

@cliss

This comment has been minimized.

Copy link

cliss commented Feb 28, 2020

  1. My idea, for reference, was something along the lines of
.lane("Photos", formatter: { "\($0.count) photos" })

...which this PR absolutely handles, and does so even more cleanly than my idea did! 🎉

@cliss cliss mentioned this pull request Feb 28, 2020
@icanzilb

This comment has been minimized.

Copy link
Owner

icanzilb commented Feb 28, 2020

@freak4pc this looks very good at first sight, let me think about it and come back with some feedback :)

Copy link
Owner

icanzilb left a comment

A single comment left, thanks so much for the PR. Once merged we'll transfer over to RxTimelane

Sources/TimelaneCombine/TimelaneCombine.swift Outdated Show resolved Hide resolved
@freak4pc freak4pc force-pushed the freak4pc:transform-value branch from 638b02d to 60c88b5 Mar 3, 2020
@freak4pc

This comment has been minimized.

Copy link
Contributor Author

freak4pc commented Mar 3, 2020

Ready for you @icanzilb

@icanzilb

This comment has been minimized.

Copy link
Owner

icanzilb commented Mar 4, 2020

Thanks @freak4pc , I've been pacing myself going through all the PRs on Timelane :)

Copy link
Owner

icanzilb left a comment

Awesome thanks!

@icanzilb icanzilb merged commit f3cc49c into icanzilb:master Mar 4, 2020
@freak4pc freak4pc deleted the freak4pc:transform-value branch Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.