Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PodSpec file to enable Cocoapods Support #3

Merged

Conversation

@KarimEbrahemAbdelaziz
Copy link
Contributor

KarimEbrahemAbdelaziz commented Mar 9, 2020

Why this PR ?

  • To be able to use TimelaneCombine with Cocoapods.

Who will upload this Pod ?

  • I would prefer you Marin to upload this pod.
@icanzilb

This comment has been minimized.

Copy link
Owner

icanzilb commented Mar 9, 2020

Thanks, isn't Combine also a framework dependency?

@KarimEbrahemAbdelaziz

This comment has been minimized.

Copy link
Contributor Author

KarimEbrahemAbdelaziz commented Mar 9, 2020

@icanzilb Sorry missed it. Check it now :)

@icanzilb icanzilb merged commit 1cd8b0f into icanzilb:master Mar 9, 2020
@icanzilb

This comment has been minimized.

Copy link
Owner

icanzilb commented Mar 9, 2020

Thanks!

@KarimEbrahemAbdelaziz

This comment has been minimized.

Copy link
Contributor Author

KarimEbrahemAbdelaziz commented Mar 9, 2020

Woooww 🎉🎉
Please notify me once it uploaded to Cocoapods.

@icanzilb

This comment has been minimized.

Copy link
Owner

icanzilb commented Mar 9, 2020

done

@KarimEbrahemAbdelaziz KarimEbrahemAbdelaziz deleted the KarimEbrahemAbdelaziz:add-cocoapods-support branch Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.