Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PodSpec file to enable Cocoapods Support #3

Merged

Conversation

KarimEbrahemAbdelaziz
Copy link
Contributor

@KarimEbrahemAbdelaziz KarimEbrahemAbdelaziz commented Mar 9, 2020

Why this PR ?

  • To be able to use TimelaneCombine with Cocoapods.

Who will upload this Pod ?

  • I would prefer you Marin to upload this pod.

@icanzilb
Copy link
Owner

@icanzilb icanzilb commented Mar 9, 2020

Thanks, isn't Combine also a framework dependency?

@KarimEbrahemAbdelaziz
Copy link
Contributor Author

@KarimEbrahemAbdelaziz KarimEbrahemAbdelaziz commented Mar 9, 2020

@icanzilb Sorry missed it. Check it now :)

@icanzilb icanzilb merged commit 1cd8b0f into icanzilb:master Mar 9, 2020
@icanzilb
Copy link
Owner

@icanzilb icanzilb commented Mar 9, 2020

Thanks!

@KarimEbrahemAbdelaziz
Copy link
Contributor Author

@KarimEbrahemAbdelaziz KarimEbrahemAbdelaziz commented Mar 9, 2020

Woooww 🎉🎉
Please notify me once it uploaded to Cocoapods.

@icanzilb
Copy link
Owner

@icanzilb icanzilb commented Mar 9, 2020

done

@KarimEbrahemAbdelaziz KarimEbrahemAbdelaziz deleted the add-cocoapods-support branch Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants