New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Carthage support #6
Add Carthage support #6
Conversation
Thanks @KarimEbrahemAbdelaziz - I'm wondering if we really need the checkouts included in this repo? What's the practice in other projects? I had a quick look at other repos and some include the carthage checkouts, some don't... |
Hey @icanzilb, As checkout folder is for carthage caching, I usually include it for the sake of consistency. So there is no room for forks to have any issue related to it. Some projects don't include it as it will be generated again (cloned) when needed from carthage. Do you think we still need it here? |
How about including the resolved cartfile but skip the actual checkouts? |
Would be good too |
@icanzilb Check it now :) |
Great, thank you! |
Thank you @icanzilb |
@KarimEbrahemAbdelaziz if you have some time - could you have a look at https://github.com/icanzilb/RxTimelane? I like how the cartage Xcode project in RxTimelane is in a sub-folder, but in RxTimelane the Xcode project is in the root. Would you be interested to re-organize the file structure and put also RxTimelane's framework project into a sub-folder? |
@icanzilb Sure interested to do it 💪🏻 |
Thank you! |
Hey @KarimEbrahemAbdelaziz - is there a carthage command you run to create the xcode framework project or do you create the project by hand? |
Hey @icanzilb - |
Why this PR ?
What is required ?
How to test it after pushing new TAG ?