Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Carthage support #6

Merged
merged 6 commits into from Mar 11, 2020

Conversation

@KarimEbrahemAbdelaziz
Copy link
Contributor

KarimEbrahemAbdelaziz commented Mar 10, 2020

Why this PR ?

  • This PR allow TimelaneCombine to be available through Carthage.

What is required ?

  1. After merging this PR you should push new TAG with new version (1.0.3)

How to test it after pushing new TAG ?

  1. Add Cartfile to XCode project.
  2. Add this to Cartfile :
github "icanzilb/TimelaneCombine" "1.0.4"
  1. Run this command in terminal
carthage update
  1. Link the output framework in you project.
@icanzilb

This comment has been minimized.

Copy link
Owner

icanzilb commented Mar 11, 2020

Thanks @KarimEbrahemAbdelaziz - I'm wondering if we really need the checkouts included in this repo? What's the practice in other projects? I had a quick look at other repos and some include the carthage checkouts, some don't...

@KarimEbrahemAbdelaziz

This comment has been minimized.

Copy link
Contributor Author

KarimEbrahemAbdelaziz commented Mar 11, 2020

Hey @icanzilb,

As checkout folder is for carthage caching, I usually include it for the sake of consistency. So there is no room for forks to have any issue related to it.
So it's personal preferences in the projects 😅😃

Some projects don't include it as it will be generated again (cloned) when needed from carthage.

Do you think we still need it here? ☺️

@icanzilb

This comment has been minimized.

Copy link
Owner

icanzilb commented Mar 11, 2020

How about including the resolved cartfile but skip the actual checkouts?

@KarimEbrahemAbdelaziz

This comment has been minimized.

Copy link
Contributor Author

KarimEbrahemAbdelaziz commented Mar 11, 2020

Would be good too 👍
I will update the PR now

@KarimEbrahemAbdelaziz

This comment has been minimized.

Copy link
Contributor Author

KarimEbrahemAbdelaziz commented Mar 11, 2020

@icanzilb Check it now :)

@icanzilb

This comment has been minimized.

Copy link
Owner

icanzilb commented Mar 11, 2020

Great, thank you!

@icanzilb icanzilb merged commit 378a6d7 into icanzilb:master Mar 11, 2020
@KarimEbrahemAbdelaziz

This comment has been minimized.

Copy link
Contributor Author

KarimEbrahemAbdelaziz commented Mar 11, 2020

Thank you @icanzilb ❤️💪🏻

@icanzilb

This comment has been minimized.

Copy link
Owner

icanzilb commented Mar 17, 2020

@KarimEbrahemAbdelaziz if you have some time - could you have a look at https://github.com/icanzilb/RxTimelane? I like how the cartage Xcode project in RxTimelane is in a sub-folder, but in RxTimelane the Xcode project is in the root. Would you be interested to re-organize the file structure and put also RxTimelane's framework project into a sub-folder?

@KarimEbrahemAbdelaziz

This comment has been minimized.

Copy link
Contributor Author

KarimEbrahemAbdelaziz commented Mar 17, 2020

@icanzilb Sure interested to do it 💪🏻
I gave it a look and I am currently working on restructure it. Wait my PR :)

@icanzilb

This comment has been minimized.

Copy link
Owner

icanzilb commented Mar 17, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.