Add Carthage support

[KarimEbrahemAbdelaziz]

Why this PR ?

• This PR allow TimelaneCombine to be available through Carthage.

What is required ?

1. After merging this PR you should push new TAG with new version (1.0.3)

How to test it after pushing new TAG ?

2. Add Cartfile to XCode project.
3. Add this to Cartfile :

github "icanzilb/TimelaneCombine" "1.0.4"

4. Run this command in terminal

carthage update

5. Link the output framework in you project.

[icanzilb]

Thanks @KarimEbrahemAbdelaziz - I'm wondering if we really need the checkouts included in this repo? What's the practice in other projects? I had a quick look at other repos and some include the carthage checkouts, some don't...

[KarimEbrahemAbdelaziz]

Hey @icanzilb,

As checkout folder is for carthage caching, I usually include it for the sake of consistency. So there is no room for forks to have any issue related to it.
So it's personal preferences in the projects 😅😃

Some projects don't include it as it will be generated again (cloned) when needed from carthage.

Do you think we still need it here? ☺️

[icanzilb]

How about including the resolved cartfile but skip the actual checkouts?

[KarimEbrahemAbdelaziz]

Would be good too 👍
I will update the PR now

[KarimEbrahemAbdelaziz]

@icanzilb Check it now :)

[icanzilb]

Great, thank you!

[KarimEbrahemAbdelaziz]

Thank you @icanzilb ❤️💪🏻

[icanzilb]

@KarimEbrahemAbdelaziz if you have some time - could you have a look at https://github.com/icanzilb/RxTimelane? I like how the cartage Xcode project in RxTimelane is in a sub-folder, but in RxTimelane the Xcode project is in the root. Would you be interested to re-organize the file structure and put also RxTimelane's framework project into a sub-folder?

[KarimEbrahemAbdelaziz]

@icanzilb Sure interested to do it 💪🏻
I gave it a look and I am currently working on restructure it. Wait my PR :)

[icanzilb]

Thank you!

[icanzilb]

Hey @KarimEbrahemAbdelaziz - is there a carthage command you run to create the xcode framework project or do you create the project by hand?

[KarimEbrahemAbdelaziz]

Hey @icanzilb -
Carthage bootstrap or Carthage build commands should create the framework.
But It seems there is a problem with Carthage support in Timelane projects. I faced this issue while I am working on Zen and I just retested Timelanes now and found the issue and working on it's fix currently.