Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carthage: Add macOS, tvOS and watchOS to shared Frameworks #9

Merged
merged 1 commit into from Mar 13, 2020

Conversation

@mRs-
Copy link
Contributor

mRs- commented Mar 13, 2020

Currently only iOS is supported for Carthage

Copy link
Owner

icanzilb left a comment

Thanks!

@icanzilb icanzilb merged commit a89002a into icanzilb:master Mar 13, 2020
@icanzilb

This comment has been minimized.

Copy link
Owner

icanzilb commented Mar 15, 2020

@mRs- I think I'll have to revert that change - it makes TimelaneCombine and RxTimelane fail to compile. Do you happen to know what issue might be?

@mRs-

This comment has been minimized.

Copy link
Contributor Author

mRs- commented Mar 15, 2020

Mmhhh that’s Strange. It’s working fine on my machine. Will look into it as soon as possible with a clean checkout

@icanzilb

This comment has been minimized.

Copy link
Owner

icanzilb commented Mar 15, 2020

That's the thing - this change isn't in a release yet. If you build TimelaneCombine with a dependency on TimelaneCore/master you will see the crash

@icanzilb

This comment has been minimized.

Copy link
Owner

icanzilb commented Mar 15, 2020

I build backwards commit by commit and the build starts crashing on this commit. (Got to add CI to this repo some time soon to catch stuff like this)

@icanzilb

This comment has been minimized.

Copy link
Owner

icanzilb commented Mar 16, 2020

Sorry, reversed that commit and updated all repos. If you still need it let's work to make a synchronized release making sure dependent repos don't break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.